[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [jdk20] RFR: 8299077: [REDO] JDK-4512626 Non-editable JTextArea provides no visual indication of
From:       Sergey Bylokhov <serb () openjdk ! org>
Date:       2022-12-23 22:58:54
Message-ID: x2ilcjEu2--mEt3EuOa3_RxFpAa4jZWHoDn9mUQlTcI=.7760a448-0062-4516-a6fc-1e2664f2dab3 () github ! com
[Download RAW message or body]

On Wed, 21 Dec 2022 19:40:09 GMT, Alexander Zuev <kizune@openjdk.org> wrote:

> > Slightly updated original fix - got rid of the extra flasher reset. Tests are \
> > fixed to be more stable and pass on the corresponding platforms.
> 
> Alexander Zuev has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Simplifying the two nested if conditions into one.

src/java.desktop/share/classes/javax/swing/text/DefaultCaret.java line 373:

> 371:     // --- FocusListener methods --------------------------
> 372: 
> 373:     /**

I guess everybody noticed the specification of this method.
> This is implemented to set the caret to visible if the component is editable.

That should be updated? And overall it seems the whole behavior change required CSR.

-------------

PR: https://git.openjdk.org/jdk20/pull/68


[prev in list] [next in list] [prev in thread] [next in thread]