[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8202931: [macos] java/awt/Choice/ChoicePopupLocation/ChoicePopupLocation.java fails [v2]
From:       Damon Nguyen <dnguyen () openjdk ! org>
Date:       2022-11-30 17:53:14
Message-ID: pu6H292sBqYHW5rSUfsu_edc8nMnLcx4IX3bxGl-i4U=.d874bbee-bdfb-4d38-a714-3fb1e92c737b () github ! com
[Download RAW message or body]

On Tue, 29 Nov 2022 05:26:11 GMT, Sergey Bylokhov <serb@openjdk.org> wrote:

> > Damon Nguyen has updated the pull request incrementally with one additional \
> > commit since the last revision: 
> > Update test to capture current screen
> 
> test/jdk/java/awt/Choice/ChoicePopupLocation/ChoicePopupLocation.java line 128:
> 
> > 126:         robot.waitForIdle();
> > 127:         if (choice.getSelectedIndex() == 0) {
> > 128:             GraphicsConfiguration ge = GraphicsEnvironment
> 
> `ge` is unused in the latest version of the patch?

My mistake. This was a remnant from when I was double-checking that the image would \
still produce correctly. But yes, I'm just using the existing instance of `ge` since \
that is determining the screen where the popup is shown.

-------------

PR: https://git.openjdk.org/jdk/pull/11277


[prev in list] [next in list] [prev in thread] [next in thread]