[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8295812: Skip the "half float" support in LittleCMS during the build
From:       Phil Race <prr () openjdk ! org>
Date:       2022-10-29 1:24:30
Message-ID: 5UbDD-wSvZrHljXyriangpq6bHln-qdNtTucLF2omA0=.fdde0d6e-7377-4813-92b3-37fe67cb06dd () github ! com
[Download RAW message or body]

On Sun, 23 Oct 2022 20:10:35 GMT, Sergey Bylokhov <serb@openjdk.org> wrote:

> The Java2d do not use "half" float in the image layouts, so we can disable it in \
> the LittleCMS library during the build. It is possible to do using \
> [this](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/native/liblcms/lcms2.h#L85) \
> public option: 
> 
> // Uncomment to get rid of the tables for "half" float support
> // #define CMS_NO_HALF_SUPPORT 1
> 
> 
> This change cuts not only the unused by java2d functions but also \
> [such](https://github.com/openjdk/jdk/blob/739769c8fc4b496f08a92225a12d07414537b6c0/src/java.desktop/share/native/liblcms/cmshalf.c#L63) \
> tables. 
> The size of liblcms decreased by 20 kB on Linux(536024 vs 515152) and 15 kB on \
> windows(246784 vs 231424). On macOS the  win is only 300 bytes.

Marked as reviewed by prr (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/10830


[prev in list] [next in list] [prev in thread] [next in thread]