[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: professional (24-bit) sampled audio support in the Windows native implementation of libjsound
From: Aleksei Ivanov <alexey.ivanov () oracle ! com>
Date: 2022-10-10 20:57:32
Message-ID: 5ca697e2-fd4f-8a4b-9f98-b536ed5bb2a7 () oracle ! com
[Download RAW message or body]
Hi,
JDK-8294904 [1] was resolved as Incomplete because there's no sample
code which demonstrates the problem. A comment was added:
Mail to submitter:
=============
Please share standalone test case/ reproducible step/ scenario to
analyze the issue better.
I should have received an email with request for clarification.
I looked through the description but it's still unclear to me how to
reproduce the problem and how to incorporate the fix you're proposing
and what the fix is. If you could provide the test case and better yet
the fix along with a regression test, it would be greatly appreciated.
The fix in the form of the diff would also help.
--
Regards,
Alexey
[1] https://bugs.openjdk.org/browse/JDK-8294904
On 09/10/2022 15:57, magare31@gmail.com wrote:
>
> Since I am new to this, and apologies for the broad email, could
> someone explain the following for the corresponding bug (JDK-8294904)?
>
> * This bug is listed as one for a generic OS, whereas I specified
> Windows (I can confirm that it is Windows only).
> * This bug is listed as "resolved" with an "incomplete resolution".
> I did provide the full solution, so I am not sure what this
> means. (Also, Oracle asked for a standalone test, which I also
> provided over email)
>
> And thanks.
>
> *From:* Kevin Rushforth <kevin.rushforth@oracle.com>
> *Sent:* Friday, September 30, 2022 8:29 AM
> *To:* magare31@gmail.com; client-libs-dev@openjdk.org;
> core-libs-dev@openjdk.org
> *Subject:* Re: professional (24-bit) sampled audio support in the
> Windows native implementation of libjsound
>
> Java Sound is in the client-libs area. You can file the bug yourself
> at https://bugreport.java.com/ if you like, or ask the sponsor of your
> bug (when one steps forward) to do it.
>
> If you want to contribute your fix, please see the contributing a
> patch section [1] in the JDK Developers Guide for the next steps.
>
> -- Kevin
>
> [1] https://openjdk.org/guide/#i-have-a-patch-what-do-i-do
>
> On 9/30/2022 4:33 AM, magare31@gmail.com wrote:
>
> Would anyone want to sponsor the following simple bug fix?
>
> - The purpose is to enable playback and recording of 24-bit
> sampled audio on Windows. This is already supported on other systems.
>
> - There is no associated bug in the bug database. I noted it as a
> "bug" as the code misunderstands the WAVE RIFF format standards.
>
> - There will be two very small changes to one Windows native cpp
> file under libjsound
>
> - I have tested the changes on a jdk build of the latest code.
>
> Also, please advise which of these two groups this belongs to:
> client libs or core libs?
>
[Attachment #3 (text/html)]
<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
Hi,<br>
<br>
JDK-8294904 [1] was resolved as Incomplete because there's no sample
code which demonstrates the problem. A comment was added:<br>
<br>
Mail to submitter:
<br>
=============
<br>
Please share standalone test case/ reproducible step/ scenario to
analyze the issue better.<br>
<br>
I should have received an email with request for clarification.<br>
<br>
I looked through the description but it's still unclear to me how to
reproduce the problem and how to incorporate the fix you're
proposing and what the fix is. If you could provide the test case
and better yet the fix along with a regression test, it would be
greatly appreciated.<br>
<br>
The fix in the form of the diff would also help.<br>
<br>
-- <br>
Regards,<br>
Alexey<br>
<br>
[1] <a class="moz-txt-link-freetext" \
href="https://bugs.openjdk.org/browse/JDK-8294904">https://bugs.openjdk.org/browse/JDK-8294904</a><br>
<br>
<div class="moz-cite-prefix">On 09/10/2022 15:57, <a \
class="moz-txt-link-abbreviated" \
href="mailto:magare31@gmail.com">magare31@gmail.com</a> wrote:<br>
</div>
<blockquote type="cite" cite="mid:028e01d8dbef$69b25070$3d16f150$@gmail.com">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style>@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}p.MsoListParagraph, li.MsoListParagraph, \
div.MsoListParagraph {mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}div.WordSection1
{page:WordSection1;}ol
{margin-bottom:0in;}ul
{margin-bottom:0in;}</style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal">Since I am new to this, and apologies for
the broad email, could someone explain the following for the
corresponding bug (JDK-8294904)?<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<ul style="margin-top:0in" type="disc">
<li class="MsoListParagraph" style="margin-left:0in;mso-list:l0 level1 \
lfo1">This bug is listed as one for a generic OS, whereas I specified Windows
(I can confirm that it is Windows only).<o:p></o:p></li>
<li class="MsoListParagraph" style="margin-left:0in;mso-list:l0 level1 \
lfo1">This bug is
listed as "resolved" with an "incomplete resolution". \
I did provide the full solution, so I am not sure what this means.
(Also, Oracle asked for a standalone test, which I also
provided over email)<o:p></o:p></li>
</ul>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">And thanks.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> Kevin Rushforth
<a class="moz-txt-link-rfc2396E" \
href="mailto:kevin.rushforth@oracle.com"><kevin.rushforth@oracle.com></a> <br> \
<b>Sent:</b> Friday, September 30, 2022 8:29 AM<br>
<b>To:</b> <a class="moz-txt-link-abbreviated" \
href="mailto:magare31@gmail.com">magare31@gmail.com</a>; <a \
class="moz-txt-link-abbreviated" \
href="mailto:client-libs-dev@openjdk.org">client-libs-dev@openjdk.org</a>; <a \
class="moz-txt-link-abbreviated" \
href="mailto:core-libs-dev@openjdk.org">core-libs-dev@openjdk.org</a><br> \
<b>Subject:</b> Re: professional (24-bit) sampled audio
support in the Windows native implementation of \
libjsound<o:p></o:p></p> </div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt">Java Sound is
in the client-libs area. You can file the bug yourself at <a \
href="https://bugreport.java.com/" moz-do-not-send="true" \
class="moz-txt-link-freetext">https://bugreport.java.com/</a> if you like, or ask \
the sponsor of your bug (when one steps forward) to do it.<br>
<br>
If you want to contribute your fix, please see the
contributing a patch section [1] in the JDK Developers Guide
for the next steps.<br>
<br>
-- Kevin<br>
<br>
[1] <a href="https://openjdk.org/guide/#i-have-a-patch-what-do-i-do" \
moz-do-not-send="true" \
class="moz-txt-link-freetext">https://openjdk.org/guide/#i-have-a-patch-what-do-i-do</a><br>
<br>
<o:p></o:p></p>
<div>
<p class="MsoNormal">On 9/30/2022 4:33 AM, <a \
href="mailto:magare31@gmail.com" moz-do-not-send="true" \
class="moz-txt-link-freetext">magare31@gmail.com</a> wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal">Would anyone want to sponsor the
following simple bug fix?<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal" style="text-indent:.5in">- The purpose is
to enable playback and recording of 24-bit sampled audio on
Windows. This is already supported on other systems.<o:p></o:p></p>
<p class="MsoNormal" style="text-indent:.5in">- There is no
associated bug in the bug database. I noted it as a "bug"
as the code misunderstands the WAVE RIFF format standards.<o:p></o:p></p>
<p class="MsoNormal" style="text-indent:.5in">- There will be
two very small changes to one Windows native cpp file under
libjsound<o:p></o:p></p>
<p class="MsoNormal" style="text-indent:.5in">- I have tested
the changes on a jdk build of the latest code.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Also, please advise which of these two
groups this belongs to: client libs or core libs?<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
</blockquote>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic