[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 4668290: unclear spec for Polygon.bounds field [v2]
From:       SWinxy <duke () openjdk ! org>
Date:       2022-09-30 21:30:25
Message-ID: tGt8IEe66tdrP8cHbwmQkTup1WB68ZuobVlLXPdmB_A=.205ea7a4-07dd-4fce-a33d-ccc9920d6cd8 () github ! com
[Download RAW message or body]

> New documentation replaces the `This value can be null.`:
> 
> When created, {@link #invalidate() invalidated}, or {@link #reset() reset},
> this becomes {@code null}. To get out of the null state,
> {@link #getBounds()} called with {@link #npoints} being greater than
> {@code 0} will transfer into a non-null {@link Rectangle}.
> 
> 
> I think I've got the reason for why it can be `null` correct, but you never know.
> 
> In javax.swing.text.html.Map, I've replaced setting the field to null with the \
> equivalent #invalidate(). This may mean we can make the field private in the \
> future.

SWinxy has updated the pull request incrementally with one additional commit since \
the last revision:

  Reword change based off of Phil's suggestion
  
  Thanks, Phil.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10417/files
  - new: https://git.openjdk.org/jdk/pull/10417/files/f08304a4..7d2e36a6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10417&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10417&range=00-01

  Stats: 4 lines in 1 file changed: 0 ins; 1 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/10417.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10417/head:pull/10417

PR: https://git.openjdk.org/jdk/pull/10417


[prev in list] [next in list] [prev in thread] [next in thread]