[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v30]
From:       Abhishek Kumar <duke () openjdk ! org>
Date:       2022-09-29 14:39:07
Message-ID: AC0k_qRSFSz7gxqCZmTQokaDmyenJv5AYKMJdo4_y_8=.95dc6843-b064-40e4-ae78-9aa02b731ee7 () github ! com
[Download RAW message or body]

On Thu, 29 Sep 2022 12:27:03 GMT, Alexey Ivanov <aivanov@openjdk.org> wrote:

> > Abhishek Kumar has updated the pull request incrementally with one additional \
> > commit since the last revision: 
> > modifiers order changed as per review comment
> 
> src/java.desktop/share/classes/sun/swing/FilePane.java line 1129:
> 
> > 1127:         static final double baseFileSize = 1000.0;
> > 1128:         final MessageFormat mf = new MessageFormat("");
> > 1129:         final NumberFormat nf = NumberFormat.getNumberInstance();
> 
> All these three new fields can be declared `private`, they aren't used anywhere \
> else. 
> For the sake of consistency, the existing fields `chooser` and `df` may also be \
> declared `private` if they're unused outside of this class. If modified, both \
> `chooser` and `df` can be `final` too, they're initialised in the constructor and \
> never changed afterwards.

@aivanov-jdk Updated the suggested changes.

-------------

PR: https://git.openjdk.org/jdk/pull/9327


[prev in list] [next in list] [prev in thread] [next in thread]