[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8054572: [macosx] JComboBox paints the border incorrectly [v7]
From:       Damon Nguyen <dnguyen () openjdk ! org>
Date:       2022-08-31 17:53:10
Message-ID: CMda7n-jNPE4l-ardt65Ip4yS3uJGNjkrkdEC_JoEKo=.f52c18fa-e58f-4182-9a59-6bf5eb38bc3b () github ! com
[Download RAW message or body]

On Fri, 26 Aug 2022 07:39:58 GMT, Prasanta Sadhukhan <psadhukhan@openjdk.org> wrote:

> > Damon Nguyen has updated the pull request incrementally with one additional \
> > commit since the last revision: 
> > Updated copyright date. Added MacOS text to test.
> 
> src/java.desktop/macosx/classes/com/apple/laf/AquaComboBoxUI.java line 471:
> 
> > 469: 
> > 470:             if (comboBox.getComponentOrientation().isLeftToRight()) {
> > 471:                 return new Rectangle(insets.left, insets.top + midHeight,
> 
> OK. Since Apple has confirmed combobox height shouldn't change with font size, we \
> can have fixed height. 
> Only thing I guess, till we sort out JDK-8023912: [macosx] JComboBox RTL \
> orientation problem lets use LTR as it seems it might give a false impression that \
> we support RTL when we dont even know if Apple supports it or not. Do you see any \
> difference with combobox if you use LTR code vs RTL code with RTL testcase present \
> in the above JBS? I dont in my BigSur. 
> It will also be good to test it out in non-retina display to see if this "22" \
> height is being shown ok there.

I don't see a difference either but was following the same logic as used in \
BasicComboBoxUI. I can remove the LTR vs RTL logic until the other issue is resolved \
if needed.

-------------

PR: https://git.openjdk.org/jdk/pull/9473


[prev in list] [next in list] [prev in thread] [next in thread]