[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8293088: Fix compilation with the new Visual Studio preprocessor
From:       Magnus Ihse Bursie <ihse () openjdk ! org>
Date:       2022-08-30 14:59:16
Message-ID: iYq1YSL2DHOKxf4o_dmgqwmECT9tyJWN11eVb2kmnhI=.936762b0-bd3a-4fa7-ae54-93c75cadc913 () github ! com
[Download RAW message or body]

On Tue, 30 Aug 2022 12:08:09 GMT, Daniel Jeliński <djelinski@openjdk.org> wrote:

> Fix compilation with Zc:preprocessor enabled. 
> 
> The flag itself will be enabled in \
> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283); I enabled the flag \
> using instructions found in Magnus's comment on that issue. 
> Windows 10 SDK version 2104 (10.0.20348.0) is required for successful compilation. \
> Compilation fails with a warning (treated as error by default) with older versions \
> of Windows 10 SDK. 
> I verified that the compilation completes successfully with this patch, both in \
> debug and in release mode, both with and without Zc:preprocessor.

Marked as reviewed by ihse (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/10080


[prev in list] [next in list] [prev in thread] [next in thread]