[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: JDK-8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar
From:       Matthias Baesken <mbaesken () openjdk ! org>
Date:       2022-08-29 7:51:13
Message-ID: 6LcFnjEKvsRvkvogUyk5NKWS4sSdxI00FsiBoYWeaVo=.28aca062-1b25-48b5-a682-0eceda998127 () github ! com
[Download RAW message or body]

On Fri, 26 Aug 2022 07:54:24 GMT, Matthias Baesken <mbaesken@openjdk.org> wrote:

> > https://docs.microsoft.com/en-us/windows/win32/api/stringapiset/nf-stringapiset-multibytetowidechar
> >  states about MultiByteToWideChar : "The function returns 0 if it does not \
> > succeed" and lists a few failure cases. However we miss checking the failure case \
> > in Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation , seems we assume the \
> > function always works nicely (in most of the JDK coding the return value is \
> > checked ).
> 
> Matthias Baesken has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Adjust added return syntax

Hi Phil are you fine with the latest revision?

-------------

PR: https://git.openjdk.org/jdk/pull/10015


[prev in list] [next in list] [prev in thread] [next in thread]