[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 7175397: The divider color is not changed to green when dragging for Nimbus LaF. [v2]
From:       Prasanta Sadhukhan <psadhukhan () openjdk ! org>
Date:       2022-08-24 4:31:34
Message-ID: JuaEfUn5nT-AuMrhS2FgRJhRBSRoP5R-qienGRwkUek=.ff9054fd-87af-4591-a380-c63a8fda2691 () github ! com
[Download RAW message or body]

On Sun, 21 Aug 2022 21:22:33 GMT, Phil Race <prr@openjdk.org> wrote:

> > Prasanta Sadhukhan has updated the pull request incrementally with one additional \
> > commit since the last revision: 
> > Revert default value
> 
> src/java.desktop/share/classes/javax/swing/plaf/nimbus/skin.laf line 21333:
> 
> 
> You wrote
> 
> The fix relies on continuousLayout property being false by default which is enabled \
> for Nimbus, which is set to default false now, same as in other L&F. I think it was \
> set true just to have documented default value in JDK-6937415 
> 
> I don't think so .. it was documenting the Nimbus default which is continuous.
> Per the javadoc for 
> https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/JSplitPane.html#setContinuousLayout(boolean)
>  
> " The default value of this property is look and feel dependent."
> 
> So if Nimbus has had it ON all this time, it is not right to change it.

Although I am not sure why it was defaulted true for Nimbus only, but I accept that \
if the default value is ON all this time, we should not change it. Modified PR to \
revert the default value to show the dragging color in non-continuousLayout mode as \
done in the closed test.

-------------

PR: https://git.openjdk.org/jdk/pull/9937


[prev in list] [next in list] [prev in thread] [next in thread]