[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 6445283: ProgressMonitorInputStream not large file aware (>2GB) [v7]
From:       Prasanta Sadhukhan <psadhukhan () openjdk ! org>
Date:       2022-07-29 11:37:27
Message-ID: PY8R0dBk5jn2I5T3GMZwcH3RTbguQ7oG7Oo8xEQnOuA=.77d6cf5c-6288-4aec-96a8-f33357005e51 () github ! com
[Download RAW message or body]

On Thu, 28 Jul 2022 20:41:38 GMT, Phil Race <prr@openjdk.org> wrote:

> > Prasanta Sadhukhan has updated the pull request incrementally with one additional \
> > commit since the last revision: 
> > Fix
> 
> src/java.desktop/share/classes/javax/swing/ProgressMonitorInputStream.java line 93:
> 
> > 91:         }
> > 92:         parentComponent = parentComponent;
> > 93:         message = message;
> 
> These are both wrong I am sure. You want to assign to this.<var> don't you ? Not \
> update the local var.

Yes. Thanks for pointing out. Updated..

-------------

PR: https://git.openjdk.org/jdk/pull/9588


[prev in list] [next in list] [prev in thread] [next in thread]