[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8244681: Add a warning for possibly lossy conversion in compound assignments [v14]
From:       Adam Sotona <asotona () openjdk ! org>
Date:       2022-07-26 8:32:00
Message-ID: KXflC0s1JhTfM6RXbd-Cnord8y7OMmsLCcl4ixuWGE0=.f8327203-6dba-42d1-9563-e6fa563aa61d () github ! com
[Download RAW message or body]

On Mon, 27 Jun 2022 09:25:58 GMT, Adam Sotona <asotona@openjdk.org> wrote:

> > Please review this patch adding new lint option, **lossy-conversions**, to javac \
> > to warn about type casts in compound assignments with possible lossy conversions. \
> >  The new lint warning is shown if the type of the right-hand operand of a \
> > compound assignment is not assignment compatible with the type of the variable. 
> > The implementation of the warning is based on similar check performed to emit \
> > "possible lossy conversion" compilation error for simple assignments.  
> > Proposed patch also include complex matrix-style test with positive and negative \
> > test cases of lossy conversions in compound assignments. 
> > Proposed patch also disables this new lint option in all affected JDK modules and \
> > libraries to allow smooth JDK build. Individual cases to address possibly lossy \
> > conversions warnings in JDK are already addressed in a separate umbrella issue \
> > and its sub-tasks. 
> > Thanks for your review,
> > Adam
> 
> Adam Sotona has updated the pull request incrementally with one additional commit \
> since the last revision: 
> re-enabled lossy conversions warnings for java.security.jgss, jdk.crypto.ec and \
> jdk.internal.le

ping to keep the PR open

-------------

PR: https://git.openjdk.org/jdk/pull/8599


[prev in list] [next in list] [prev in thread] [next in thread]