[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB
From:       Alexey Ivanov <aivanov () openjdk ! org>
Date:       2022-06-30 20:05:45
Message-ID: zoME5oGfdtBVgdxizAwoMdF6i3O4t9MaFCbH9ffkDaU=.4ccd0f69-0efd-4bea-8867-18516e306d40 () github ! com
[Download RAW message or body]

On Thu, 30 Jun 2022 16:31:21 GMT, Harshitha Onkar <honkar@openjdk.org> wrote:

> > JFileChooser - empty file size issue fixed. 
> > For empty file, now the size 0 bytes.
> > Manual Test Case "ZeroFileSizeCheck.java" created.
> 
> test/jdk/javax/swing/JFileChooser/ZeroFileSizeCheck.java line 74:
> 
> > 72:             PassFailJFrame.positionTestFrame(frame,
> > 73:                     PassFailJFrame.Position.HORIZONTAL);
> > 74:         });
> 
> @kumarabhi006 You might have to update `addTestFrame & positonTestFrame` to \
> `addTestWindow & positionTestWindow` due to recent PassFailJFrame changes. Probably \
> pull in the latest code. PassFailJFrame changes: \
> https://github.com/openjdk/jdk/pull/9300

> @kumarabhi006 You might have to update `addTestFrame & positonTestFrame` to \
> `addTestWindow & positionTestWindow` due to recent PassFailJFrame changes. Probably \
> pull in the latest code. PassFailJFrame changes: #9300

You *have* to update. Otherwise, the test will fail after integration.

-------------

PR: https://git.openjdk.org/jdk/pull/9327


[prev in list] [next in list] [prev in thread] [next in thread]