[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Integrated: JDK-8289238: Refactoring changes to PassFailJFrame Test Framework
From:       Harshitha Onkar <honkar () openjdk ! org>
Date:       2022-06-29 18:39:42
Message-ID: ZnZCURxXdj-Udaev2ag0dloSptIWYH9nsYnvMkz7ivo=.842c5be7-a825-4400-ba94-773a83bf0026 () github ! com
[Download RAW message or body]

On Tue, 28 Jun 2022 00:58:42 GMT, Harshitha Onkar <honkar@openjdk.org> wrote:

> Currently PassFailJFrame.positionTestFrame() and PassFailJFrame.addTestFrame() take \
> Frame as input parameter, this has been changed to Window. 
> Refactored the above method names to reflect the functionality & input parameter \
> type - addTestWindow(), positionTestWindow()
> 
> Additionally added test fail reason to `forceFail()` to avoid NPE.
> 
> Benefits of the change -
> 
> - Since Window is a parent class, this would allow the test frame to be a \
>                 Window/Frame/Dialog and not be restricted to a Frame.
> - Code reusability - no need to have separate methods to manage Frame and Window
> - Additionally it would allow proper clean-up of window and its container \
> subclasses which are added to the PassFailJFrame.

This pull request has now been integrated.

Changeset: 15efb2bd
Author:    Harshitha Onkar <honkar@openjdk.org>
Committer: Alexey Ivanov <aivanov@openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/15efb2bdeb73e4e255dcc864be1a83450a2beaa8
                
Stats:     43 lines in 8 files changed: 3 ins; 2 del; 38 mod

8289238: Refactoring changes to PassFailJFrame Test Framework

Reviewed-by: azvegint, aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/9300


[prev in list] [next in list] [prev in thread] [next in thread]