[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8285306: Fix typos in java.desktop [v6]
From:       Andrey Turbanov <aturbanov () openjdk ! org>
Date:       2022-06-23 19:44:56
Message-ID: PPSTUbLpJnkQgZUlXyikcp9Vjq1D0J8ly5qZQfxJBX4=.51002137-8a00-4dfe-af6b-c5c152be0d1c () github ! com
[Download RAW message or body]

On Fri, 13 May 2022 16:53:00 GMT, Magnus Ihse Bursie <ihse@openjdk.org> wrote:

> > I ran `codespell` on the `src/java.desktop` directory, and accepted those changes \
> > where it indeed discovered real typos. 
> > I ignored typos in public methods and variables. Maybe they can be fixed later on \
> > without much fanfare, if they are in internal classes. Typos in exposed APIs are \
> > likely here to stay. 
> > I will update copyright years using a script before pushing (otherwise like every \
> > second change would be a copyright update, making reviewing much harder). 
> > The long term goal here is to make tooling support for running `codespell`. The \
> > trouble with automating this is of course all false positives. But before even \
> > trying to solve that issue, all true positives must be fixed. Hence this PR.
> 
> Magnus Ihse Bursie has updated the pull request incrementally with 17 additional \
> commits since the last revision: 
> - Update src/java.desktop/windows/classes/sun/awt/windows/WPrinterJob.java
> 
> Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk@users.noreply.github.com>
> - Update src/java.desktop/unix/classes/sun/awt/X11/XBaseMenuWindow.java
> 
> Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk@users.noreply.github.com>
> - Update src/java.desktop/unix/classes/sun/awt/X11/XBaseMenuWindow.java
> 
> Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk@users.noreply.github.com>
> - Update src/java.desktop/share/classes/sun/swing/SwingUtilities2.java
> 
> Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk@users.noreply.github.com>
> - Update src/java.desktop/share/classes/sun/swing/SwingUtilities2.java
> 
> Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk@users.noreply.github.com>
> - Update src/java.desktop/share/classes/sun/awt/image/ImagingLib.java
> 
> Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk@users.noreply.github.com>
> - Update src/java.desktop/share/classes/sun/awt/image/ImagingLib.java
> 
> Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk@users.noreply.github.com>
> - Update src/java.desktop/share/classes/javax/swing/tree/FixedHeightLayoutCache.java
>  
> Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk@users.noreply.github.com>
> - Update src/java.desktop/share/classes/javax/swing/text/html/parser/TagStack.java
> 
> Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk@users.noreply.github.com>
> - Update src/java.desktop/share/classes/javax/swing/text/html/CSS.java
> 
> Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk@users.noreply.github.com>
> - ... and 7 more: https://git.openjdk.org/jdk/compare/40c585cd...98e635a5

Marked as reviewed by aturbanov (Committer).

-------------

PR: https://git.openjdk.org/jdk/pull/8328


[prev in list] [next in list] [prev in thread] [next in thread]