[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8284956: Potential leak awtImageData/color_data when initializes X11GraphicsEnvironment [v2
From:       Zhengyu Gu <zgu () openjdk ! java ! net>
Date:       2022-04-28 18:31:49
Message-ID: pmItocL68kNaviV1-QhPfnaPZImHVe82KmotKarFFFY=.dd698ae7-b743-468d-9955-2178c9398b90 () github ! com
[Download RAW message or body]

On Thu, 28 Apr 2022 13:07:22 GMT, Aleksey Shipilev <shade@openjdk.org> wrote:

> What about `_ColorData::img_grays`, `_ColorData::awt_Colors`, `_ColorData::img_oda_*`?

`_ColorData::img_oda_*` are not malloc'd


 awt_data->color_data->img_oda_red   = &(std_img_oda_red[0][0]);
 awt_data->color_data->img_oda_green = &(std_img_oda_green[0][0]);
 awt_data->color_data->img_oda_blue  = &(std_img_oda_blue[0][0]);

and `std_img_oda_*` are defined as 

JNIEXPORT extern sgn_ordered_dither_array std_img_oda_red;
JNIEXPORT extern sgn_ordered_dither_array std_img_oda_green;
JNIEXPORT extern sgn_ordered_dither_array std_img_oda_blue;

-------------

PR: https://git.openjdk.java.net/jdk/pull/8317
[prev in list] [next in list] [prev in thread] [next in thread]