[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8277463: JFileChooser with Metal L&F doesn't show non-canonical UNC path in - Look in [v3]
From:       Masanori Yano <myano () openjdk ! java ! net>
Date:       2021-12-23 9:40:01
Message-ID: fET09WOmLF0WhTZuzaJBiV2-GTgDGpdu-e_75-BTjyk=.66ef891d-c1f1-4c29-a069-6fdc3b1ece8c () github ! com
[Download RAW message or body]

On Tue, 21 Dec 2021 05:28:17 GMT, Sergey Bylokhov <serb@openjdk.org> wrote:

> > I fixed the test as it was pointed out to me.
> 
> Now it cannot be compiled due to "unreported exception \
> java.lang.ClassNotFoundException; must be caught or declared to be thrown" from the \
> setLookAndFeel(); Note that the new version still has a race, the \
> invokeLater/setLookAndFeel can be executed later than the code in the \
> showOpenDialog(), so the code in showOpenDialog may use the wrong L&F properties, \
> can we move the showOpenDialog to the EDT as well?

Sorry, I've modified the test case. If showOpenDialog() is called on EDT, this test \
does not exit at judge button pressing. So I would to change createInstructionUI() to \
call on main thread. This method sets properties and event handlers before showing \
UI, so does not need call on EDT.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6796


[prev in list] [next in list] [prev in thread] [next in thread]