[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Integrated: 8196017: java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails
From:       Alexander Zuev <kizune () openjdk ! java ! net>
Date:       2021-10-30 10:04:14
Message-ID: D5I_uVztmxbM2nqoWEEKK2AF2mhI5RLp_gmCFa2zIHk=.e2b4f391-5a85-45a4-9211-919f62bc3a90 () github ! com
[Download RAW message or body]

On Wed, 27 Oct 2021 00:52:10 GMT, Alexander Zuev <kizune@openjdk.org> wrote:

> The problem here is that due to the approximation of the coordinates when converting
> to and from screen cordinate system on screen with 125% magnification 
> two things can happen:
> 1. New mouse position calculated can be 149/149 which is the same as the starting position
> and system can refuse to generate new mouse event which causes false positive of the test
> since second mouse motion listener was never called;
> 2. Even if event is generated the resulting reported coordinates can differ by 1 pixel
> in any of the directions;
> 
> To solve it i moved away the target point to make sure that move event always generated and
> comparing expected and actual coordinates with approximation of +/- 1 pixel.

This pull request has now been integrated.

Changeset: b7104ba9
Author:    Alexander Zuev <kizune@openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/b7104ba9a9006ab65e08ea9d7db22e72611ed07c
Stats:     24 lines in 2 files changed: 9 ins; 6 del; 9 mod

8196017: java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails

Reviewed-by: serb

-------------

PR: https://git.openjdk.java.net/jdk/pull/6128
[prev in list] [next in list] [prev in thread] [next in thread]