[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8273634: [TEST_BUG] Improve javax/swing/text/ParagraphView/6364882/bug6364882.java
From:       Phil Race <prr () openjdk ! java ! net>
Date:       2021-09-29 16:53:38
Message-ID: L3hiC2K1aKN0AIR6MC3mycMbLsiD7zdhefVNpgbKFJg=.e8044d93-7b3a-4fbb-8e2c-1ac4cf917fdc () github ! com
[Download RAW message or body]

On Thu, 23 Sep 2021 19:19:34 GMT, Alexey Ivanov <aivanov@openjdk.org> wrote:

> The test is being moved from the closed to open.
> 
> I updated the `bug6364882.java` test so that it's headless now. If it fails, the \
> image of the `editorPane` is saved for analysis. I also added more asserts which \
> verify: 
> • the first three lines are aligned to the right edge;
> • the fourth line isn't justified and its width is less than 3/4 of the width;
> • the fifth and sixth lines have width less than that of the fourth line and have \
> the same width. 
> There's an option to show the UI for visual inspection as well as to save the image \
> even if the test passes; use `-show` and/or `-save` parameters to the test \
> correspondingly. 
> [1] [JDK-6364882](https://bugs.openjdk.java.net/browse/JDK-6364882): Last line of a \
> paragraph should not be justified

"Unfortunately, it doesn't save the image if an exception is thrown. I overlooked \
this fact."

oops :-)

-------------

PR: https://git.openjdk.java.net/jdk/pull/5661


[prev in list] [next in list] [prev in thread] [next in thread]