[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Integrated: 8239502: [TEST_BUG] Test javax/swing/text/FlowView/6318524/bug6318524.java never fails
From:       Alexey Ivanov <aivanov () openjdk ! java ! net>
Date:       2021-09-28 19:20:08
Message-ID: EOwcbeBio_Mmtv9LVVvBInDDHMxsikSnY80_DWXMGQI=.69e1247d-6846-4e6b-bd3d-a21061fc9ef4 () github ! com
[Download RAW message or body]

On Thu, 23 Sep 2021 18:41:38 GMT, Alexey Ivanov <aivanov@openjdk.org> wrote:

> The test is being moved from the closed to open. It's nearly a complete re-write of \
> the original test. 
> I made the test headless by painting into image.
> 
> To detect failure, the test uses the position of the caret at the end of first line \
> of the paragraph where the wrapping occurs. 
> I made sure that the updated test reproduces the original problem in \
> [JDK-6318524](https://bugs.openjdk.java.net/browse/JDK-6318524). (There are some \
> tweaks required to compile it with JDK 6.) The updated test fails when run with \
> 6-b52. In fact, it also fails with 6-b53 up to 6-b76 where \
> [JDK-6364882](https://bugs.openjdk.java.net/browse/JDK-6364882) is fixed. 
> The behaviour in 6-b76 coincides with that in the latest JDK.
> 
> There are three parameters provided for debugging purposes:
> • `-show`: Show frame for visual inspection
> • `-save`: Save *the start image* after the first paragraph is justified, and \
> *the last image* before it's checked that the first paragraph remains justified • \
> `-saveAll`: Save images for all the intermediate steps 
> [1] [JDK-6318524](https://bugs.openjdk.java.net/browse/JDK-6318524): Regression: \
> views in paragraph are not children of Paragraph.Row is some cases [2] \
> [JDK-6364882](https://bugs.openjdk.java.net/browse/JDK-6364882): Last line of a \
> paragraph should not be justified

This pull request has now been integrated.

Changeset: b7425b63
Author:    Alexey Ivanov <aivanov@openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/b7425b63f6b69ba8709664377b4e037176ab6139
                
Stats:     194 lines in 1 file changed: 194 ins; 0 del; 0 mod

8239502: [TEST_BUG] Test javax/swing/text/FlowView/6318524/bug6318524.java never \
fails

Reviewed-by: serb

-------------

PR: https://git.openjdk.java.net/jdk/pull/5660


[prev in list] [next in list] [prev in thread] [next in thread]