[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8274396: Suppress more warnings on non-serializable non-transient intance fields in client 
From:       Iris Clark <iris () openjdk ! java ! net>
Date:       2021-09-28 16:49:39
Message-ID: ZzOlWQM5GpIOS60QEV8ThLdWVrZfsiB8You4ZhVC_TY=.3c992318-53ea-4b48-a1ec-e517bc2ea253 () github ! com
[Download RAW message or body]

On Mon, 27 Sep 2021 22:48:24 GMT, Joe Darcy <darcy@openjdk.org> wrote:

> > Follow-up changes to JDK-8231334. , augmentations to javac's Xlint:serial \
> > checking are out for review (#5709) and various client libraries would need some \
> > changes to pass under the expanded checks. 
> > The changes are to suppress warnings where non-transient fields in serializable \
> > types are not declared with a type statically known to be serializable. That \
> > isn't necessarily a correctness issues, but it does merit further scrutiny. 
> > I'll run a script to update the copyright year before pushing.
> 
> Joe Darcy has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Add comments requested in code review.

I like the comments indicating why the suppression is needed.

-------------

Marked as reviewed by iris (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5723


[prev in list] [next in list] [prev in thread] [next in thread]