[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8269223: -Xcheck:jni WARNINGs working with fonts on Linux [v6]
From:       Sergey Bylokhov <serb () openjdk ! java ! net>
Date:       2021-08-17 23:39:27
Message-ID: dE8NKpT2SnZC6j0kqmdVx5wmkH4NzRHJEu6c35KO6-w=.4651408b-54d6-4c73-8229-3614e6fe2cf9 () github ! com
[Download RAW message or body]

On Mon, 16 Aug 2021 07:51:12 GMT, Maxim Kartashev \
<github.com+28651297+mkartashev@openjdk.org> wrote:

> > Added an `ExceptionCheck()` followed by `ExceptionDescribe()` and \
> > `ExceptionClear()` immediately after the Java calls made from the callback \
> > function `ReadTTFontFileFunc()` in `freetypeScaler.c`.  
> > The exception(s) need to be cleared because we're not returning immediately to \
> > Java that would've been able to handle them gracefully. And in order not to loose \
> > the exception entirely (even though the return value would also indicate an error \
> > condition), print out the exception with `ExceptionDescribe()` to aid in \
> > debugging.
> 
> Maxim Kartashev has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Address PR comments
> 
> 1. Added code to log the exception if it occurred when running a flushBuffer's \
> runnable. The logging is minimal in order to avoid replacing the exception with \
> another one before it reaches Java. 
> 2. Made the test not dependent on headful code as per @prrace suggestions.

Marked as reviewed by serb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/4572


[prev in list] [next in list] [prev in thread] [next in thread]