[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8267940: [macos] java/awt/print/Dialog/DialogOwnerTest.java fails [v2]
From:       Phil Race <prr () openjdk ! java ! net>
Date:       2021-07-21 22:25:52
Message-ID: jUCMpUIXZLOKcbGN4Jid-Hs0J9SnbUX2MQTj4cSUaDc=.27bed0fc-033b-40e1-a5bd-188f4be88c47 () github ! com
[Download RAW message or body]

On Wed, 21 Jul 2021 04:19:03 GMT, Prasanta Sadhukhan <psadhukhan@openjdk.org> wrote:

> > This test fails to follow the test instruction which says ""On Top" print dialogs \
> > should stay behind the "Owner Window"  but it seems to be the behaviour right \
> > from jdk11b18 where DialogOwner class and this test was inducted via JDK-8203796 \
> > not only in mac but in windows too ie, "On Top" print dialogs should stay behind \
> > the "Owner Window" as per instruction but is not. On Top print dialogs actually \
> > stay above the "owner window" 
> > I guess there is some ambiguity in test instruction or clarity in understanding \
> > test instructions is not there because Test instructions says "For On Top tests \
> > all windows should stay *behind* the owner window." but "Owner Window" \
> > instruction says "For tests that are 'Owned' or 'On Top' the dialog must always \
> > stay *above* this window. "  
> > Rectified the test instruction to be same as owner window instruction
> 
> Prasanta Sadhukhan has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Fix instruction

Marked as reviewed by prr (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/4823


[prev in list] [next in list] [prev in thread] [next in thread]