[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [jdk17] RFR: 8266079: Lanai: AlphaComposite shows differences on Metal compared
From:       Sergey Bylokhov <serb () openjdk ! java ! net>
Date:       2021-06-28 22:48:05
Message-ID: _ckINhzlkfObwA0ncLZCaoFzWItgZUyR-4Bg3evQYME=.890f1ed7-d977-4f2a-9125-3a0fef580440 () github ! com
[Download RAW message or body]

On Wed, 23 Jun 2021 12:15:03 GMT, Alexey Ushakov <avu@openjdk.org> wrote:

> > Implemented blit via compute kernel
> 
> Alexey Ushakov has refreshed the contents of this pull request, and previous \
> commits have been removed. The incremental views will show differences compared to \
> the previous content of the PR. The pull request contains one new commit since the \
> last revision: 
> 8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL
> 
> Keep MTLLayer opacity in sync with window content view

src/java.desktop/macosx/native/libawt_lwawt/awt/CWrapper.m line 349:

> 347:         if ([window.contentView.layer isKindOfClass:[CAMetalLayer class]]) {
> 348:             [window.contentView.layer setOpaque:(BOOL)opaque];
> 349:         }

This class "CWrapper" is intended to be a simple wrapper on top of cocoa methods, the \
changed method above is expected to call the "NSWindow#setOpaque" only. So you need \
to place "window.contentView.layer setOpaque" in some other place(native or java).

-------------

PR: https://git.openjdk.java.net/jdk17/pull/62


[prev in list] [next in list] [prev in thread] [next in thread]