[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8267521: Post JEP 411 refactoring: maximum covering > 50K [v3]
From:       Phil Race <prr () openjdk ! java ! net>
Date:       2021-05-30 17:44:23
Message-ID: nJPC4wkzrEB1S-50zDd6rH7nAYjitSHUl02KPNfVYeU=.cdfeb19c-16a2-47ee-b562-bade124de429 () github ! com
[Download RAW message or body]

On Fri, 21 May 2021 20:37:30 GMT, Weijun Wang <weijun@openjdk.org> wrote:

> > The code change refactors classes that have a `SuppressWarnings("removal")` \
> > annotation that covers more than 50KB of code. The big annotation is often quite \
> > faraway from the actual deprecated API usage it is suppressing, and with the \
> > annotation covering too big a portion it's easy to call other deprecated methods \
> > without being noticed. 
> > The code change shows some common solutions to avoid such too wide annotations:
> > 
> > 1. Extract calls into a method and add annotation on that method
> > 2. Assign the return value of a deprecated method call to a new local variable \
> > and add annotation on the declaration, and then assign that value to the original \
> > l-value if not void. The local variable will be called `tmp` if later reassigned \
> > or `dummy` if it will be discarded. 3. Put declaration and assignment into a \
> > single statement if possible. 4. Rewrite code to achieve #3 above.
> > 
> > I'll add a copyright year update commit before integration.
> 
> Weijun Wang has updated the pull request incrementally with one additional commit \
> since the last revision: 
> update FtpClient.java

Marked as reviewed by prr (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/4138


[prev in list] [next in list] [prev in thread] [next in thread]