[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    [OpenJDK 2D-Dev] Integrated: 8256372: [macos] Unexpected symbol was displayed on JTextField with Mon
From:       Phil Race <prr () openjdk ! java ! net>
Date:       2021-05-20 19:51:47
Message-ID: At2MKH3_Ry3TCCb0e6fpAhnssOuUQHhKSz8dAZqxljM=.8ebb4aca-066b-44c1-9a00-169b4f041cce () github ! com
[Download RAW message or body]

On Tue, 18 May 2021 15:55:09 GMT, Phil Race <prr@openjdk.org> wrote:

> See the bug report for lots of explanation.
> The short version (not that short) is that Swing adds a new line char to editable TextComponents
> It used to work because harfbuzz asked CoreText which mapped it to an invisible glyph
> Now harfbuzz does its own processing of AAT fonts it is different.
> Harfbuzz looks up the mapping for this but there is none so it gets a missing glyph.
> 
> Solution: Since HB now does AAT processing we can dispense with all the special handling of that case
> and core text and just treat AAT fonts like OT fonts. 
> This means its gets the same mapping we get when not using Layout.
> 
> And the test passes on all platforms .. not just macOS ..

This pull request has now been integrated.

Changeset: 005d8a7f
Author:    Phil Race <prr@openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/005d8a7fca8b4d9519d2bde0a7cdbbece1cd3981
Stats:     1425 lines in 9 files changed: 65 ins; 1352 del; 8 mod

8256372: [macos] Unexpected symbol was displayed on JTextField with Monospaced font

Reviewed-by: erikj, serb

-------------

PR: https://git.openjdk.java.net/jdk/pull/4097
[prev in list] [next in list] [prev in thread] [next in thread]