[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8256372: [macos] Unexpected symbol was displayed on JTextField with Monosp
From:       Sergey Bylokhov <serb () openjdk ! java ! net>
Date:       2021-05-20 19:45:32
Message-ID: HnJoGBSvDJ-iiPiAaTgsb66sHxoA4_gV7KqSRRZX7_o=.a05056f5-0392-43f1-99e2-c4e9c58199f7 () github ! com
[Download RAW message or body]

On Tue, 18 May 2021 15:55:09 GMT, Phil Race <prr@openjdk.org> wrote:

> See the bug report for lots of explanation.
> The short version (not that short) is that Swing adds a new line char to editable TextComponents
> It used to work because harfbuzz asked CoreText which mapped it to an invisible glyph
> Now harfbuzz does its own processing of AAT fonts it is different.
> Harfbuzz looks up the mapping for this but there is none so it gets a missing glyph.
> 
> Solution: Since HB now does AAT processing we can dispense with all the special handling of that case
> and core text and just treat AAT fonts like OT fonts. 
> This means its gets the same mapping we get when not using Layout.
> 
> And the test passes on all platforms .. not just macOS ..

Marked as reviewed by serb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/4097
[prev in list] [next in list] [prev in thread] [next in thread]