[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    [OpenJDK 2D-Dev] Withdrawn: 8257733: Move module-specific data from make to respective module
From:       duke <duke () openjdk ! java ! net>
Date:       2021-04-21 13:38:41
Message-ID: pDP5xeFMzByh8WRd5O5mePAKLL8iQl1fsbrjzbOz-AQ=.ce5414cf-66ca-4c58-b49e-4e52df238b71 () github ! com
[Download RAW message or body]

On Thu, 3 Dec 2020 23:44:20 GMT, Magnus Ihse Bursie <ihse@openjdk.org> wrote:

> A lot (but not all) of the data in make/data is tied to a specific module. For \
> instance, the publicsuffixlist is used by java.base, and fontconfig by \
> java.desktop. (A few directories, like mainmanifest, is *actually* used by make for \
> the whole build.)  
> These data files should move to the module they belong to. The are, after all, \
> "source code" for that module that is "compiler" into resulting deliverables, for \
> that module. (But the "source code" language is not Java or C, but typically a \
> highly domain specific language or data format, and the "compilation" is, often, a \
> specialized transformation.)  
> This misplacement of the data directory is most visible at code review time. When \
> such data is changed, most of the time build-dev (or the new build label) is \
> involved, even though this has nothing to do with the build. While this is \
> annoying, a worse problem is if the actual team that needs to review the patch \
> (i.e., the team owning the module) is missed in the review. 
> ### Modules reviewed
> 
> - [x] java.base
> - [x] java.desktop
> - [x] jdk.compiler
> - [x] java.se

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1611


[prev in list] [next in list] [prev in thread] [next in thread]