[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8264475: CopyArea ignores clip state in metal rendering pipeline
From:       Jayathirth D V <jdv () openjdk ! java ! net>
Date:       2021-03-31 15:06:27
Message-ID: 86-OA0614MggDHTo2H9Sap5OlbQvXgKus1E8dKRrYUU=.c400d0ef-77f3-4e4a-8f67-a683241458e7 () github ! com
[Download RAW message or body]

On Wed, 31 Mar 2021 12:39:49 GMT, Ajit Ghaisas <aghaisas@openjdk.org> wrote:

> I tested this fix. No regressions were observed.
> 
> Using MTLBlitCommandEncoder is intuitive when metal resource copying needs to be \
> done. I suggest to add a comment (may be as a method description or in code where \
> we do the actual copy) to mention why we use MTLRenderCommandEncoder and not \
> MTLBlitCommandEncoder.

Thanks Ajit for testing the fix. I have added comment mentioning why we use \
MTLRenderCommandEncoder and not MTLBlitCommandEncoder.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3283


[prev in list] [next in list] [prev in thread] [next in thread]