[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    [OpenJDK 2D-Dev] Integrated: 8263981: java.awt.image.ComponentSampleModel equals/hashcode use numBan
From:       Aleksey Shipilev <shade () openjdk ! java ! net>
Date:       2021-03-24 7:04:42
Message-ID: xOA_i1hgRMajqtjo9pgYQofmm1ZeJIrb1RrAt5gaNyw=.343d9045-af5a-4f78-b4f9-eeda44e56f1f () github ! com
[Download RAW message or body]

On Mon, 22 Mar 2021 15:55:16 GMT, Aleksey Shipilev <shade@openjdk.org> wrote:

> SonarCloud reports the problem in ComponentSampleModel.equals:
>   Correct one of the identical sub-expressions on both sides of operator "&&"
> 
> ...near "this.numBands == that.numBands". It is checked twice. hashCode also processes it twice.

This pull request has now been integrated.

Changeset: cb776edf
Author:    Aleksey Shipilev <shade@openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/cb776edf
Stats:     4 lines in 1 file changed: 0 ins; 3 del; 1 mod

8263981: java.awt.image.ComponentSampleModel equals/hashcode use numBands twice

Reviewed-by: serb, azvegint

-------------

PR: https://git.openjdk.java.net/jdk/pull/3125
[prev in list] [next in list] [prev in thread] [next in thread]