[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v21]
From:       Anton Kozlov <akozlov () openjdk ! java ! net>
Date:       2021-02-26 19:17:12
Message-ID: ZfRwLBDhh3K6u3NaWzLWVyoYqBuZVJbipXCZKzPclBs=.bedc9c24-2178-400a-8868-fbbb61b298cc () github ! com
[Download RAW message or body]

> Please review the implementation of JEP 391: macOS/AArch64 Port.
> 
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and \
> windows/aarch64. 
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks \
>                 JDK-8253817, JDK-8253818)
> * src/hotspot/os_cpu/bsd_aarch64: copy of os_cpu/linux_aarch64 with necessary \
>                 adjustments (JDK-8253819)
> * src/hotspot/share, test/hotspot/gtest: support of write-xor-execute (W^X), \
> required on macOS/AArch64 platform. It's implemented with \
> pthread_jit_write_protect_np provided by Apple. The W^X mode is local to a thread, \
> so W^X mode change relates to the java thread state change (for java threads). In \
> most cases, JVM executes in write-only mode, except when calling a generated stub \
> like SafeFetch, which requires a temporary switch to execute-only mode. The same \
> execute-only mode is enabled when a java thread executes in java or native states. \
>                 This approach of managing W^X mode turned out to be simple and \
>                 efficient enough.
> * src/jdk.hotspot.agent: serviceability agent implementation (JDK-8254941)

Anton Kozlov has updated the pull request incrementally with two additional commits \
since the last revision:

 - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos
 - Minor fixes

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2200/files
  - new: https://git.openjdk.java.net/jdk/pull/2200/files/241aedee..663cb4a1

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr"00&range 
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr"00&range-20

  Stats: 85 lines in 5 files changed: 0 ins; 80 del; 5 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2200.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2200/head:pull/2200

PR: https://git.openjdk.java.net/jdk/pull/2200


[prev in list] [next in list] [prev in thread] [next in thread]