[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8196301: java/awt/print/PrinterJob/Margins.java times out [v2]
From:       Sergey Bylokhov <serb () openjdk ! java ! net>
Date:       2021-02-22 22:25:40
Message-ID: XKZE-LbRYIQ0EHFpntdfFTdzu1evQoQXey4N5JYwsOA=.f5f334a8-e70a-4621-9fec-839ffdee3d63 () github ! com
[Download RAW message or body]

On Fri, 19 Feb 2021 04:34:51 GMT, Prasanta Sadhukhan <psadhukhan@openjdk.org> wrote:

> > This test was timing out in windows in mach5 nightly testing. Investigation \
> > reveals that 70% of the time, it is failing due to printer being chosen was \
> > Microsoft Print to PDF which opens up a File Save Dialog when "OK" was clicked in \
> > printer pagedialog. Since no user intervention is done to dismiss the modal \
> > filedialog, so subsequent pagedialog was not dismissed resulting in timeout. \
> > Other times, it was found that "One Note" software printer was used as default \
> > printerservice which again, opens up a OneNote app which again gets focus and \
> > obscure pagedialog so PageDialog did not get dismissed. Updated test to ignore \
> > "Print To PDF", "OneNote" and "XPS Document Writer"(which again opens filedialog \
> > like PDF printer) and run it for several iteration in mach5 platforms which is \
> > ok. Link in JBS.
> 
> Prasanta Sadhukhan has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Remove pdf printer check

test/jdk/java/awt/print/PrinterJob/Margins.java line 78:

> 76:             robot.keyRelease(KeyEvent.VK_ENTER);
> 77:         });
> 78:         t1.start();

Don't you need to wait until the t1(and others) thread completes? You call start() \
but the actual execution may not start till the end of the test.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2598


[prev in list] [next in list] [prev in thread] [next in thread]