[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    [OpenJDK 2D-Dev] Integrated: 8259522: Apply java.io.Serial annotations in java.desktop
From:       Sergey Bylokhov <serb () openjdk ! java ! net>
Date:       2021-01-15 0:31:01
Message-ID: G3x8Wr0SIEUSodquvRdnsV88amw32tPuXweX4QBcSXU=.f7d4d3fd-d9c1-4092-b223-49bc919e980d () github ! com
[Download RAW message or body]

On Mon, 11 Jan 2021 06:21:52 GMT, Sergey Bylokhov <serb@openjdk.org> wrote:

> Please review the application of @java.io.Serial annotation (JDK-8202385) to types \
> in the desktop module to enable stricter compile-time checking of \
> serialization-related declarations. 
> This annotation can be applied to these methods in the module:
> 
> private void writeObject(java.io.ObjectOutputStream stream) throws IOException
> private void readObject(java.io.ObjectInputStream stream) throws IOException, \
> ClassNotFoundException private void readObjectNoData() throws ObjectStreamException
> ANY-ACCESS-MODIFIER Object writeReplace() throws ObjectStreamException
> ANY-ACCESS-MODIFIER Object readResolve() throws ObjectStreamException
> private static final ObjectStreamField[] serialPersistentFields
> private static final long serialVersionUID
> 
> Notes:
> - I have tried to update the comments for serialVersionUID as accurately as \
> possible, but mostly based on the source code history and bugs in JBS where that \
>                 field was added
> - Some of the readObject/writeObject methods in the javax.swing package does not \
> have a spec, because this package and some others are excluded from the \
> serialization specification. 
> A similar fix was implemented for java.base module as well:
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2019-August/062046.html

This pull request has now been integrated.

Changeset: 978bed6c
Author:    Sergey Bylokhov <serb@openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/978bed6c
Stats:     3424 lines in 343 files changed: 2264 ins; 287 del; 873 mod

8259522: Apply java.io.Serial annotations in java.desktop

Reviewed-by: aivanov, psadhukhan

-------------

PR: https://git.openjdk.java.net/jdk/pull/2020


[prev in list] [next in list] [prev in thread] [next in thread]