[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] RFR: 8198390: Test MultiResolutionDrawImageWithTransformTest.java fails when -e
From: Sergey Bylokhov <serb () openjdk ! java ! net>
Date: 2020-11-30 3:45:55
Message-ID: ndiC8BCXGXfxTZ8y-Tr2Xl0jUrvzr9CpSPFVmu6qwy8=.708527cf-7ee9-4291-a7bc-c9eb20dbab89 () github ! com
[Download RAW message or body]
On Fri, 20 Nov 2020 00:10:48 GMT, Sergey Bylokhov <serb@openjdk.org> wrote:
> The method in which the assertion fails called from the different places, sometimes \
> bounds are passed(dx/dy) and the transform only once here: \
> https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/sun/java2d/SunGraphics2D.java#L3571
>
> For the case when the transform is passed we have an assertion that checks some \
> assumptions about the(dx/dy):
> - The dx1/dy1 should be equal to 0, which means both values are not changed by the \
> method.
> - The dx2/dy2 should be equal to the image size(MRI) -> are not changed by the \
> method as well.
> The second assertion is wrong. The dx2/dy2 passed to the method contains the size \
> of the initial image(MRI), and an assertion checks it against the size of the \
> "resolution variant" which may have a different DPI/resolution/size.
Any volunteers for a review?
-------------
PR: https://git.openjdk.java.net/jdk/pull/1333
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic