[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8254370: Update the classes in the java.awt.color package
From:       Phil Race <prr () openjdk ! java ! net>
Date:       2020-10-25 1:23:36
Message-ID: yaUkeuDVxQy9jdHWzdNL4qQMIN9SMtILTR4asy0Pem4=.85b2144b-991f-4b23-9933-56b3f3585f2f () github ! com
[Download RAW message or body]

On Sun, 25 Oct 2020 01:06:18 GMT, Sergey Bylokhov <serb@openjdk.org> wrote:

> > src/java.desktop/share/classes/java/awt/color/ICC_ProfileRGB.java line 209:
> > 
> > > 207:      *         {@code REDCOMPONENT}, {@code GREENCOMPONENT}, or
> > > 208:      *         {@code BLUECOMPONENT}
> > > 209:      * @throws ProfileDataException if the profile does not specify the
> > 
> > You said no CSR is needed but you document a previously undocumented exception, \
> > so I think a CSR is warranted
> 
> CSR is needed and linked from the JBS, and after a few attempts, it is referenced \
> from this pull request a few comments above.

Ok. There's a very weird sequence above of it being added, and you removing it and \
whatever so it is confusing. I'll find the CSR and review / ok it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/612


[prev in list] [next in list] [prev in thread] [next in thread]