[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8251123: doclint warnings about missing javadoc tags and comments [v2]
From:       Phil Race <prr () openjdk ! java ! net>
Date:       2020-10-03 19:36:38
Message-ID: afqcPoSnlob0W3uBFdJhPvJjQooTQtt0tKpVRF_CLn8=.c5c5d822-dd61-4009-958f-022abb53998f () github ! com
[Download RAW message or body]

On Sat, 3 Oct 2020 00:31:48 GMT, Sergey Bylokhov <serb@openjdk.org> wrote:

> > We have a number of missing javadoc tags and comments in the desktop module.
> > Most of the missing comments are related to the serialized form.
> > 
> > The fix:
> > - Adds missing comments to the non-static/non-transient fields(even private) of \
> >                 the "serializable" classes
> > - Adds comments to the "serializable" classes even if those classes are \
> >                 non-public
> > - Fixes references/adds missing tags to the special methods(like \
> >                 readObject/writeObject)
> > - Delete the java.awt.PeerFixer class.
> > 
> > I need advice about what exact change should be reviewed in  the CSR(except \
> > PeerFixer removal) 
> > Note that in some cases I added the comments to the "implementation details", so \
> > I did not specify it fully. 
> > The old review request:
> > https://mail.openjdk.java.net/pipermail/beans-dev/2020-August/000423.html
> 
> Sergey Bylokhov has updated the pull request incrementally with two additional \
> commits since the last revision: 
> - Update ScrollPane.java
> - Update based on the feedback

Marked as reviewed by prr (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/369


[prev in list] [next in list] [prev in thread] [next in thread]