[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    [OpenJDK 2D-Dev] Integrated: 8252070: Some platform-specific BLIT optimizations are not effective
From:       Sergey Bylokhov <serb () openjdk ! java ! net>
Date:       2020-09-20 4:36:08
Message-ID: fS9lAEI4zDGyYNXQVy5GIyRamziYZ3yhRMpzciUG_ro=.ddfb6a0a-71bf-48ea-90f0-692d69dc45dd () github ! com
[Download RAW message or body]

On Thu, 10 Sep 2020 22:47:53 GMT, Sergey Bylokhov <serb@openjdk.org> wrote:

> Some of our code assumes that the native system(XRender, D3D, OGL) makes some
> effective optimizations, but in some cases, we can do better.
> 
> One of the areas for improvement is direct blitting. If the source is much
> bigger than the destination we should not try to copy to the non-existent area
> and could cut coordinates accordingly.
> 
> The actual change is:
> 951         Rectangle dst =
> 952                 new Rectangle(dx, dy, w, h).intersection(dstData.getBounds());
> 953         if (dst.isEmpty()) {
> 972                 // return
> 975         }
> 979         sx += dst.x - dx;
> 980         sy += dst.y - dy;
> 
> See performance data and some additional comments:
> https://bugs.openjdk.java.net/browse/JDK-8252070?focusedCommentId=14365864&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14365864
>  
> The old review request:
> https://mail.openjdk.java.net/pipermail/2d-dev/2020-August/011007.html

This pull request has now been integrated.

Changeset: 3d88d387
Author:    Sergey Bylokhov <serb@openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/3d88d387
Stats:     80 lines in 1 file changed: 27 ins; 41 del; 12 mod

8252070: Some platform-specific BLIT optimizations are not effective

Reviewed-by: prr, jdv

-------------

PR: https://git.openjdk.java.net/jdk/pull/121


[prev in list] [next in list] [prev in thread] [next in thread]