[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8171303 sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & L
From:       Sergey Bylokhov <Sergey.Bylokhov () oracle ! com>
Date:       2020-08-25 23:35:33
Message-ID: e93e37a2-b17b-c755-967b-eb9ddf7097f2 () oracle ! com
[Download RAW message or body]

On 25.08.2020 14:59, Philip Race wrote:
> This is fine but
> 1) I like to see the bug under which you fixed it in the @bug list.

It is not a product bug and the test isn't reworked, so it is not necessary to have \
this test fix in the list of bugs

> 2) I am not sure I see how all the various reasons for this test failing can be \
> explained by this.

In the HiDPI mode the VolatileImage internally have twice more pixels than \
BufferedImage, so when we draw the data to the VolatileImage and then scale it back \
to the size of the BufferedImage for comparison, the test fails.

> 
> -phil.
> 
> On 8/25/20, 1:37 PM, Sergey Bylokhov wrote:
> > Hello.
> > Please review the fix for jdk/client.
> > 
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8171303
> > Fix: http://cr.openjdk.java.net/~serb/8171303/webrev.00
> > 
> > This the only test which was created to check different types of interpolation.
> > It checks the rendering to the VolatileImage and uses BufferedImage as a gold \
> > image. But it does not take into account that rendering to the VolatileImage \
> > might be affected by the HiDPI support.
> > 


-- 
Best regards, Sergey.


[prev in list] [next in list] [prev in thread] [next in thread]