[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] RFR : 8200281: Add missing @Override annotations in ImageIO plugins
From: Dmitry Markov <dmitry.markov () oracle ! com>
Date: 2020-08-20 18:08:09
Message-ID: F72F6D79-9200-4BF1-AE76-8F97BA6030C3 () oracle ! com
[Download RAW message or body]
+1
Regards,
Dmitry
> On 19 Aug 2020, at 23:03, Alexey Ivanov <alexey.ivanov@oracle.com> wrote:
>
> Looks good.
>
> Regards,
> Alexey
>
> On 18/08/2020 15:23, Kumar Abhishek wrote:
> > Hi Alexey,
> >
> > Please find the updated Webrev link here:- \
> > http://cr.openjdk.java.net/~arapte/Abhishek/8200281/webrev.05 I have updated the \
> > missed annotation.
> >
> > Thanks,
> > Abhishek
> > -----Original Message-----
> > From: Alexey Ivanov
> > Sent: Tuesday, August 18, 2020 2:26 AM
> > To: Kumar Abhishek <kumar.z.abhishek@oracle.com>
> > Cc: Dmitry Markov <dmitry.markov@oracle.com>; Philip Race \
> > <philip.race@oracle.com>; 2d-dev <2d-dev@openjdk.java.net>
> > Subject: Re: [OpenJDK 2D-Dev] RFR : 8200281: Add missing @Override annotations in \
> > ImageIO plugins
> > Hi Abhishek,
> >
> > We're getting closer but some annotations from those I listed in my previous \
> > email are still missing:
> > *BMPImageReader.java*
> >
> > 2067 public Boolean run() {
> >
> >
> > *JPEGImageReader.java*
> >
> > 954 protected ImageTypeSpecifier produce() {
> >
> >
> > *TIFFImageWriter.java*
> >
> > I also found one more missing @Override:
> > 3687 public Raster getTile(int tileX, int tileY) {
> >
> >
> > *WBMPImageReader.java*
> >
> > Shall we also sort the imports? I mean move:
> > 43 import java.io.IOException;
> > 44 import java.util.ArrayList;
> > 45 import java.util.Iterator;
> > to be after
> > 33 import java.awt.image.WritableRaster;
> >
> > Though It's fine with me as is.
> >
> >
> > Regards,
> > Alexey
> >
> > <SNIP>
[Attachment #3 (unknown)]
<html><head><meta http-equiv="Content-Type" content="text/html; \
charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: \
space; line-break: after-white-space;" class="">+1<div class=""><br \
class=""></div><div class="">Regards,</div><div class="">Dmitry<br class=""><div><br \
class=""><blockquote type="cite" class=""><div class="">On 19 Aug 2020, at 23:03, \
Alexey Ivanov <<a href="mailto:alexey.ivanov@oracle.com" \
class="">alexey.ivanov@oracle.com</a>> wrote:</div><br \
class="Apple-interchange-newline"><div class=""><span style="caret-color: rgb(0, 0, \
0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: \
normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: \
0px; text-transform: none; white-space: normal; word-spacing: 0px; \
-webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline \
!important;" class="">Looks good.</span><br style="caret-color: rgb(0, 0, 0); \
font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: \
normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: \
0px; text-transform: none; white-space: normal; word-spacing: 0px; \
-webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br \
style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; \
font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: \
normal; text-align: start; text-indent: 0px; text-transform: none; white-space: \
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" \
class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: \
12px; font-style: normal; font-variant-caps: normal; font-weight: normal; \
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; \
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration: none; float: none; display: inline !important;" \
class="">Regards,</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; \
font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; \
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; \
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: \
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; \
font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; \
text-transform: none; white-space: normal; word-spacing: 0px; \
-webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline \
!important;" class="">Alexey</span><br style="caret-color: rgb(0, 0, 0); font-family: \
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; \
font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; \
text-transform: none; white-space: normal; word-spacing: 0px; \
-webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br \
style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; \
font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: \
normal; text-align: start; text-indent: 0px; text-transform: none; white-space: \
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" \
class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: \
12px; font-style: normal; font-variant-caps: normal; font-weight: normal; \
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; \
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration: none; float: none; display: inline !important;" class="">On \
18/08/2020 15:23, Kumar Abhishek wrote:</span><br style="caret-color: rgb(0, 0, 0); \
font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: \
normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: \
0px; text-transform: none; white-space: normal; word-spacing: 0px; \
-webkit-text-stroke-width: 0px; text-decoration: none;" class=""><blockquote \
type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; \
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: \
auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; \
widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; \
-webkit-text-stroke-width: 0px; text-decoration: none;" class="">Hi Alexey,<br \
class=""><br class="">Please find the updated Webrev link here:- <a \
href="http://cr.openjdk.java.net/~arapte/Abhishek/8200281/webrev.05" \
class="">http://cr.openjdk.java.net/~arapte/Abhishek/8200281/webrev.05</a><br \
class="">I have updated the missed annotation.<br class=""><br class=""><br \
class="">Thanks,<br class="">Abhishek<br class="">-----Original Message-----<br \
class="">From: Alexey Ivanov<br class="">Sent: Tuesday, August 18, 2020 2:26 AM<br \
class="">To: Kumar Abhishek <<a href="mailto:kumar.z.abhishek@oracle.com" \
class="">kumar.z.abhishek@oracle.com</a>><br class="">Cc: Dmitry Markov <<a \
href="mailto:dmitry.markov@oracle.com" class="">dmitry.markov@oracle.com</a>>; \
Philip Race <<a href="mailto:philip.race@oracle.com" \
class="">philip.race@oracle.com</a>>; 2d-dev <<a \
href="mailto:2d-dev@openjdk.java.net" class="">2d-dev@openjdk.java.net</a>><br \
class="">Subject: Re: [OpenJDK 2D-Dev] RFR : 8200281: Add missing @Override \
annotations in ImageIO plugins<br class=""><br class="">Hi Abhishek,<br class=""><br \
class="">We're getting closer but some annotations from those I listed in my previous \
email are still missing:<br class=""><br class="">*BMPImageReader.java*<br \
class=""><br class="">2067 \
public Boolean run() {<br class=""><br class=""><br \
class="">*JPEGImageReader.java*<br class=""><br \
class="">954 \
protected ImageTypeSpecifier produce() {<br class=""><br class=""><br \
class="">*TIFFImageWriter.java*<br class=""><br class="">I also found one more \
missing @Override:<br class="">3687 public Raster getTile(int \
tileX, int tileY) {<br class=""><br class=""><br class="">*WBMPImageReader.java*<br \
class=""><br class="">Shall we also sort the imports? I mean move:<br \
class=""> 43 import java.io.IOException;<br class=""> 44 \
import java.util.ArrayList;<br class=""> 45 import java.util.Iterator;<br \
class="">to be after<br class=""> 33 import \
java.awt.image.WritableRaster;<br class=""><br class="">Though It's fine with me as \
is.<br class=""><br class=""><br class="">Regards,<br class="">Alexey<br class=""><br \
class=""><SNIP></blockquote></div></blockquote></div><br \
class=""></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic