[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8250894 : Provide a configure option to build and run against the platform
From:       Erik Joelsson <erik.joelsson () oracle ! com>
Date:       2020-07-31 20:04:43
Message-ID: 330f38eb-3b6b-b1b4-48c4-ead72cd99f40 () oracle ! com
[Download RAW message or body]

On 2020-07-31 12:56, Philip Race wrote:
> Done : http://cr.openjdk.java.net/~prr/8250894.1/
>
> Although it makes the webrev noisier ..
>
Yes, but I prefer future readability. :)

Looks good now, thanks!

/Erik

> -phil.
>
> On 7/31/20, 11:48 AM, Erik Joelsson wrote:
>> Hello Phil,
>>
>> Looks good. The only thing I would ask is that you indent everything 
>> in the else clause in Awt2dLibraries.gmk.
>>
>> Thanks
>>
>> /Erik
>>
>> On 2020-07-31 10:58, Philip Race wrote:
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8250894
>>> webrev : http://cr.openjdk.java.net/~prr/8250894/
>>>
>>> Since https://bugs.openjdk.java.net/browse/JDK-8249821 has now 
>>> separated
>>> out libharfbuzz from libfontmanager, it would be natural for distros
>>> to want to link against the libharfbuzz that they distribute with the
>>> platform, as is done for libfreetype. But there is no way to do it.
>>>
>>> This fix adds a --with-harfbuzz=system configure option.
>>> The valid values are system and bundled.
>>> If specifying system it checks to see if you have the harfbuzz 
>>> development package installed
>>>
>>> Like similar options it is only useful on platforms that distribute
>>> libharfbuzz, so there is no need to try to support windows and macOS 
>>> for this option
>>> and it will fast fail at configure time on those platforms.
>>>
>>> I have verified this fix on Ubuntu 20.04 LTS.
>>>
>>> -phil.
>>>
>>>
[prev in list] [next in list] [prev in thread] [next in thread]