[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] RFR [XS]: 8248468: java/awt/font/DefaultFontTest/DefaultFontTest.java fails in
From: Jayathirth D v <JAYATHIRTH.D.V () ORACLE ! COM>
Date: 2020-07-01 8:16:01
Message-ID: 5CC0B754-7DD8-4788-A1A5-A664A409EF11 () ORACLE ! COM
[Download RAW message or body]
Looks good to me.
Thanks,
Jay
> On 01-Jul-2020, at 12:10 PM, Baesken, Matthias <matthias.baesken@sap.com> wrote:
>
> Ping … would be nice to get a review …
>
> From: Baesken, Matthias
> Sent: Montag, 29. Juni 2020 10:06
> To: 2d-dev@openjdk.java.net <mailto:2d-dev@openjdk.java.net>
> Subject: RFR [XS]: 8248468: java/awt/font/DefaultFontTest/DefaultFontTest.java \
> fails in SunFontManager.findFont2D
> Hello, please review this small fix.
>
> It was noticed that the jtreg test \
> java/awt/font/DefaultFontTest/DefaultFontTest.java fails on one of our RedHat 7.1 \
> machines with this exception :
> java.lang.NullPointerException: Cannot invoke \
> "String.toLowerCase(java.util.Locale)" because "name" is null at \
> java.desktop/sun.font.SunFontManager.findFont2D(SunFontManager.java:1891) at \
> java.desktop/sun.font.SunFontManager.getDefaultPhysicalFont(SunFontManager.java:1036)
> at DefaultFontTest.main(DefaultFontTest.java:57)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:64)
> at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:564)
> at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
> at java.base/java.lang.Thread.run(Thread.java:832)
>
>
> Looks like name.toLowerCase(Locale.ENGLISH); is called on a font name that is \
> null, this should be checked / avoided .
>
>
> Bug/webrev :
>
> https://bugs.openjdk.java.net/browse/JDK-8248468 \
> <https://bugs.openjdk.java.net/browse/JDK-8248468>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8248468.0/ \
> <http://cr.openjdk.java.net/~mbaesken/webrevs/8248468.0/>
>
> Thanks, Matthias
[Attachment #3 (unknown)]
<html><head><meta http-equiv="Content-Type" content="text/html; \
charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; \
line-break: after-white-space;" class="">Looks good to me.<div class=""><br \
class=""></div><div class="">Thanks,</div><div class="">Jay<br class=""><div><br \
class=""><blockquote type="cite" class=""><div class="">On 01-Jul-2020, at 12:10 PM, \
Baesken, Matthias <<a href="mailto:matthias.baesken@sap.com" \
class="">matthias.baesken@sap.com</a>> wrote:</div><br \
class="Apple-interchange-newline"><div class=""><div class="WordSection1" \
style="page: WordSection1; caret-color: rgb(0, 0, 0); font-family: Helvetica; \
font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; \
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; \
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration: none;"><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; \
font-family: Calibri, sans-serif;" class=""><span lang="EN-US" style="" class="">Ping \
… would be nice to get a review …</span><span lang="EN-US" class=""><o:p \
class=""></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; \
font-family: Calibri, sans-serif;" class=""><span lang="EN-US" class=""><o:p \
class=""> </o:p></span></div><div class=""><div style="border-style: solid none \
none; border-top-width: 1pt; border-top-color: rgb(225, 225, 225); padding: 3pt 0cm \
0cm;" class=""><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: \
Calibri, sans-serif;" class=""><b class=""><span lang="EN-US" \
class="">From:</span></b><span lang="EN-US" class=""><span \
class="Apple-converted-space"> </span>Baesken, Matthias<span \
class="Apple-converted-space"> </span><br class=""><b class="">Sent:</b><span \
class="Apple-converted-space"> </span>Montag, 29. Juni 2020 10:06<br class=""><b \
class="">To:</b><span class="Apple-converted-space"> </span><a \
href="mailto:2d-dev@openjdk.java.net" style="color: rgb(149, 79, 114); \
text-decoration: underline;" class="">2d-dev@openjdk.java.net</a><br class=""><b \
class="">Subject:</b><span class="Apple-converted-space"> </span>RFR [XS]: \
8248468: java/awt/font/DefaultFontTest/DefaultFontTest.java fails in \
SunFontManager.findFont2D<o:p class=""></o:p></span></div></div></div><div \
style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" \
class=""><o:p class=""> </o:p></div><div style="margin: 0cm 0cm 0.0001pt; \
font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span lang="EN-US" \
class="">Hello, please review this small fix.<o:p class=""></o:p></span></div><div \
style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" \
class=""><span lang="EN-US" class=""><o:p class=""> </o:p></span></div><p \
class="MsoNormal" style="margin: 0cm 0cm 12pt; font-size: 11pt; font-family: Calibri, \
sans-serif;"><span lang="EN-US" class="">It was noticed that the jtreg test \
java/awt/font/DefaultFontTest/DefaultFontTest.java fails on one of our RedHat 7.1 \
machines with this exception :<br class=""><br \
class="">java.lang.NullPointerException: Cannot invoke \
"String.toLowerCase(java.util.Locale)" because "name" is null<br class="">at \
java.desktop/sun.font.SunFontManager.findFont2D(SunFontManager.java:1891)<br \
class="">at java.desktop/sun.font.SunFontManager.getDefaultPhysicalFont(SunFontManager.java:1036)<br \
class="">at DefaultFontTest.main(DefaultFontTest.java:57)<br class="">at \
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)<br \
class="">at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:64)<br \
class="">at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)<br \
class="">at java.base/java.lang.reflect.Method.invoke(Method.java:564)<br class="">at \
com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)<br \
class="">at java.base/java.lang.Thread.run(Thread.java:832)<o:p \
class=""></o:p></span></p><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; \
font-family: Calibri, sans-serif;" class=""><span lang="EN-US" class=""><br \
class="">Looks like name.toLowerCase(Locale.ENGLISH); is called on a font \
name that is null, this should be checked / avoided .<o:p \
class=""></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; \
font-family: Calibri, sans-serif;" class=""><span lang="EN-US" class=""><o:p \
class=""> </o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: \
11pt; font-family: Calibri, sans-serif;" class=""><span lang="EN-US" class=""><o:p \
class=""> </o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: \
11pt; font-family: Calibri, sans-serif;" class=""><span lang="EN-US" class=""><o:p \
class=""> </o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: \
11pt; font-family: Calibri, sans-serif;" class=""><span lang="EN-US" \
class="">Bug/webrev :<o:p class=""></o:p></span></div><div style="margin: 0cm 0cm \
0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span \
lang="EN-US" class=""><o:p class=""> </o:p></span></div><div style="margin: 0cm \
0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><a \
href="https://bugs.openjdk.java.net/browse/JDK-8248468" style="color: rgb(149, 79, \
114); text-decoration: underline;" \
class="">https://bugs.openjdk.java.net/browse/JDK-8248468</a><o:p \
class=""></o:p></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; \
font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div><div \
style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" \
class=""><a href="http://cr.openjdk.java.net/~mbaesken/webrevs/8248468.0/" \
style="color: rgb(149, 79, 114); text-decoration: underline;" \
class="">http://cr.openjdk.java.net/~mbaesken/webrevs/8248468.0/</a><o:p \
class=""></o:p></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; \
font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div><div \
style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" \
class=""><o:p class=""> </o:p></div><div style="margin: 0cm 0cm 0.0001pt; \
font-size: 11pt; font-family: Calibri, sans-serif;" class="">Thanks, \
Matthias</div></div></div></blockquote></div><br class=""></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic