[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports - (
From:       Mikael Vidstedt <mikael.vidstedt () oracle ! com>
Date:       2020-05-07 0:50:22
Message-ID: 3D91D7AE-11DB-4E80-B9A2-DAF6A96E24E6 () oracle ! com
[Download RAW message or body]


Sergey/Shura, thank you for the reviews. I reverted the Jemmy changes, and found some \
additional Sun Studio cleanups.

New webrev here:

webrev: http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.01/client/open/webrev/
                
incremental: http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.01/client.incr/open/webrev/


Cheers,
Mikael

> On May 3, 2020, at 10:12 PM, Mikael Vidstedt <mikael.vidstedt@oracle.com> wrote:
> 
> 
> Please review this change which implements part of JEP 381:
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8244224
> webrev: http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.00/client/open/webrev/
>                 
> JEP: https://bugs.openjdk.java.net/browse/JDK-8241787
> 
> 
> Note: When reviewing this, please be aware that this exercise was *extremely* \
> mind-numbing, so I appreciate your help reviewing all the individual changes \
> carefully. You may want to get that coffee cup filled up (or whatever keeps you \
> awake)! 
> 
> Background:
> 
> Because of the size of the total patch and wide range of areas touched, this patch \
> is one out of in total six partial patches which together make up the necessary \
> changes to remove the Solaris and SPARC ports. The other patches are being sent out \
> for review to mailing lists appropriate for the respective areas the touch. An \
> email will be sent to jdk-dev summarizing all the patches/reviews. To be clear: \
> this patch is *not* in itself complete and stand-alone - all of the (six) patches \
> are needed to form a complete patch. Some changes in this patch may look wrong or \
> incomplete unless also looking at the corresponding changes in other areas. 
> For convenience, I'm including a link below[1] to the full webrev, but in case you \
> have comments on changes in other areas, outside of the files included in this \
> thread, please provide those comments directly in the thread on the appropriate \
> mailing list for that area if possible. 
> In case it helps, the changes were effectively produced by searching for and \
> updating any code mentioning "solaris", "sparc", "solstudio", "sunos", etc. More \
> information about the areas impacted can be found in the JEP itself. 
> 
> Testing:
> 
> A slightly earlier version of this change successfully passed tier1-8, as well as \
> client tier1-2. Additional testing will be done after the first round of reviews \
> has been completed. 
> Cheers,
> Mikael
> 
> [1] http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.00/all/open/webrev/
> 


[prev in list] [next in list] [prev in thread] [next in thread]