[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] [15] RFR JDK-8195841: PNGImageReader.readNullTerminatedString() doesnt check fo
From: Jayathirth D v <JAYATHIRTH.D.V () ORACLE ! COM>
Date: 2020-04-17 3:59:12
Message-ID: B37A6C2F-69E1-4E2A-9CB6-2AED9F88DD99 () ORACLE ! COM
[Download RAW message or body]
Thanks for both the reviews.
Yes embed link and it is going to wrong bug. Thanks for pointing to proper link.
Regards,
Jay
> On 17-Apr-2020, at 3:21 AM, Philip Race <philip.race@oracle.com> wrote:
>
> +1
>
> BTW your bug link goes to the wrong bug, should go here : \
> https://bugs.openjdk.java.net/browse/JDK-8195841 \
> <https://bugs.openjdk.java.net/browse/JDK-8195841>
> -phil.
>
> On 4/13/20, 2:40 AM, Jayathirth D v wrote:
> >
> > Hello All,
> >
> > Please review the following fix for JDK 15:
> >
> > Bug : https://bugs.openjdk.java.net/browse/JDK-8195841 \
> > <https://bugs.openjdk.java.net/browse/JDK-6532025> Webrev : \
> > http://cr.openjdk.java.net/~jdv/8195841/ \
> > <http://cr.openjdk.java.net/%7Ejdv/8195841/>
> > Issue : PNGImageReader doesn't check null terminated string for keyword when its \
> > length is maximum length Solution : After we are done with reading the keyword \
> > stream make sure that last byte read is NUL.
> > Thanks,
> > Jay
[Attachment #3 (unknown)]
<html><head><meta http-equiv="Content-Type" content="text/html; \
charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; \
line-break: after-white-space;" class="">Thanks for both the reviews.<div \
class="">Yes embed link and it is going to wrong bug. Thanks for pointing to proper \
link.</div><div class=""><br class=""></div><div class="">Regards,</div><div \
class="">Jay<br class=""><div><br class=""><blockquote type="cite" class=""><div \
class="">On 17-Apr-2020, at 3:21 AM, Philip Race <<a \
href="mailto:philip.race@oracle.com" class="">philip.race@oracle.com</a>> \
wrote:</div><br class="Apple-interchange-newline"><div class="">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type" class="">
<div bgcolor="#FFFFFF" text="#000000" class="">
+1<br class="">
<br class="">
BTW your bug link goes to the wrong bug, should go here :
<a class="moz-txt-link-freetext" \
href="https://bugs.openjdk.java.net/browse/JDK-8195841">https://bugs.openjdk.java.net/browse/JDK-8195841</a><br \
class=""> <br class="">
-phil.<br class="">
<br class="">
On 4/13/20, 2:40 AM, Jayathirth D v wrote:
<blockquote cite="mid:244E5BF8-DE38-4AEE-92E7-773E78192FF2@ORACLE.COM" \
type="cite" class="">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" class="">
<span style="caret-color: rgb(0, 0, 0);" class="">Hello All,</span>
<div class="" style="caret-color: rgb(0, 0, 0);"><br class="">
</div>
<div class="" style="caret-color: rgb(0, 0, 0);">Please review the following \
fix for JDK 15:</div> <div class="" style="caret-color: rgb(0, 0, 0);"><br class="">
</div>
<div class="" style="caret-color: rgb(0, 0, 0);">Bug : <a \
moz-do-not-send="true" href="https://bugs.openjdk.java.net/browse/JDK-6532025" \
class="">https://bugs.openjdk.java.net/browse/JDK-8195841</a></div> <div class="" \
style="caret-color: rgb(0, 0, 0);">Webrev : <a moz-do-not-send="true" \
href="http://cr.openjdk.java.net/%7Ejdv/8195841/" \
class="">http://cr.openjdk.java.net/~jdv/8195841/</a> </div> <div class="" \
style="caret-color: rgb(0, 0, 0);"><br class=""> </div>
<div class="" style="caret-color: rgb(0, 0, 0);">Issue : PNGImageReader doesn't \
check null terminated string for keyword when its length is maximum length</div>
<div class="" style="caret-color: rgb(0, 0, 0);">Solution : After we are done \
with reading the keyword stream make sure that last byte read is NUL.</div>
<div class="" style="caret-color: rgb(0, 0, 0);"><br class="">
</div>
<div class="" style="caret-color: rgb(0, 0, 0);">Thanks,</div>
<div class="" style="caret-color: rgb(0, 0, 0);">Jay</div>
</blockquote>
</div>
</div></blockquote></div><br class=""></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic