[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8196181 sun/java2d/GdiRendering/InsetClipping.java fails
From:       Jayathirth D v <JAYATHIRTH.D.V () ORACLE ! COM>
Date:       2020-04-16 11:51:09
Message-ID: 1B07B1B8-1A9F-4E0D-9273-DC8B5DFBCB7F () ORACLE ! COM
[Download RAW message or body]

Looks good to me.

Thanks,
Jay

> On 13-Apr-2020, at 6:57 PM, Sergey Bylokhov <Sergey.Bylokhov@oracle.com> wrote:
> 
> Hello.
> Please review the fix for jdk/client.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8196181
> Fix: http://cr.openjdk.java.net/~serb/8196181/webrev.01
> 
> The test tries to take a color of the pixel near the frame's insets,
> exactly after the frame's decoration. The problem is that we cannot
> report the size of the insets if decoration has a fractional size in
> the user's space.
> (if the size is 7 pixels and scale 2 we may report 3 or 4, both are inaccurate)
> 
> As a fix, I suggest checking another pixel which also can be used to
> verify initial bug JDK-4873505(JDK 1.4.2).
> 
> 
> -- 
> Best regards, Sergey.

[prev in list] [next in list] [prev in thread] [next in thread]