[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] RFR: 8223935: PIT: java/awt/font/WindowsIndicFonts.java fails on windows10
From: Philip Race <philip.race () oracle ! com>
Date: 2020-04-07 1:14:08
Message-ID: 5E8BD3E0.5060004 () oracle ! com
[Download RAW message or body]
Hi,
1) I missed this email, and as I am sure you know it was pushed a while back
2) SkippedException seems to be an EE thing, so not possible and
inappropriate from looking
at its ties to concurrency
3) It would defeat the purpose of the fix to throw any Exception in such
a case.
-phil.
On 3/18/20, 1:39 AM, Langer, Christoph wrote:
>
> Hi Phil,
>
> good to see this finally getting fixed.
>
> Changes look good to me. I'm wondering, though, whether a
> SkippedException should be thrown when there fonts are not found? On
> the other hand, the test still probably always tests something, even
> if certain fonts are missing.
>
> Best regards
>
> Christoph
>
> *From:*2d-dev <2d-dev-bounces@openjdk.java.net> *On Behalf Of *Philip Race
> *Sent:* Mittwoch, 18. März 2020 01:00
> *To:* Sergey Bylokhov <Sergey.Bylokhov@oracle.com>
> *Cc:* 2d-dev <2d-dev@openjdk.java.net>
> *Subject:* Re: [OpenJDK 2D-Dev] RFR: 8223935: PIT:
> java/awt/font/WindowsIndicFonts.java fails on windows10
>
> Done.
>
> http://cr.openjdk.java.net/~prr/8223935.1/
> <http://cr.openjdk.java.net/%7Eprr/8223935.1/>
>
> Log looks like this :-
>
> SysRootDir=C:\\Windows
> found:C:\\Windows\\fonts\\mangal.ttf for Devanagari
> found:C:\\Windows\\fonts\\vrinda.ttf for Bengali
> found:C:\\Windows\\fonts\\raavi.ttf for Gurmukhi
> found:C:\\Windows\\fonts\\shruti.ttf for Gujurati
> found:C:\\Windows\\fonts\\kalinga.ttf for Oriya
> found:C:\\Windows\\fonts\\latha.ttf for Tamil
> found:C:\\Windows\\fonts\\gautami.ttf for Telugu
> found:C:\\Windows\\fonts\\tunga.ttf for Kannada
> found:C:\\Windows\\fonts\\kartika.ttf for Malayalam
> found:C:\\Windows\\fonts\\iskpota.ttf for Sinhala
> found:C:\\Windows\\fonts\\dokchamp.ttf for Thai
> found:C:\\Windows\\fonts\\dokchamp.ttf for Lao
> found:C:\\Windows\\fonts\\khmerui.ttf for Khmer
> found:C:\\Windows\\fonts\\monbaiti.ttf for Mongolian
>
> -phil.
>
>
>
> On 3/17/20, 11:24 AM, Sergey Bylokhov wrote:
>
> Hi, Phil.
>
> Probably it is better to use "%SYSTEMROOT%\Fonts" instead of
> "c:\\windows\\fonts"?
>
> On 3/17/20 9:34 am, Philip Race wrote:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8223935
> Webrev: http://cr.openjdk.java.net/~prr/8223935/
> <http://cr.openjdk.java.net/%7Eprr/8223935/>
>
> WindowsIndicFonts has been failing randomly depending on
> whether a test system has the Indic fonts installed.
> This updates the test to not fail on systems which don't have
> the expected
> fonts installed in the typical default location.
>
> -phil.
>
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi,<br>
<br>
1) I missed this email, and as I am sure you know it was pushed a
while back<br>
2) SkippedException seems to be an EE thing, so not possible and
inappropriate from looking<br>
at its ties to concurrency<br>
3) It would defeat the purpose of the fix to throw any Exception in
such a case.<br>
<br>
<br>
-phil.<br>
<br>
On 3/18/20, 1:39 AM, Langer, Christoph wrote:
<blockquote
cite="mid:AM0PR02MB5714D26503974355A47D83AD8AF70@AM0PR02MB5714.eurprd02.prod.outlook.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;
color:black;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span style="color:windowtext">Hi \
Phil,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:windowtext"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:windowtext">good to see
this finally getting fixed.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:windowtext"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:windowtext">Changes look
good to me. I’m wondering, though, whether a
SkippedException should be thrown when there fonts are not
found? On the other hand, the test still probably always
tests something, even if certain fonts are missing.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:windowtext"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:windowtext">Best \
regards<o:p></o:p></span></p>
<p class="MsoNormal"><span \
style="color:windowtext">Christoph<o:p></o:p></span></p> <p class="MsoNormal"><o:p> \
</o:p></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0cm
0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span \
style="color:windowtext">From:</span></b><span style="color:windowtext"> 2d-dev
<a class="moz-txt-link-rfc2396E" \
href="mailto:2d-dev-bounces@openjdk.java.net"><2d-dev-bounces@openjdk.java.net></a>
<b>On Behalf Of </b>Philip Race<br>
<b>Sent:</b> Mittwoch, 18. März 2020 01:00<br>
<b>To:</b> Sergey Bylokhov
<a class="moz-txt-link-rfc2396E" \
href="mailto:Sergey.Bylokhov@oracle.com"><Sergey.Bylokhov@oracle.com></a><br>
<b>Cc:</b> 2d-dev <a class="moz-txt-link-rfc2396E" \
href="mailto:2d-dev@openjdk.java.net"><2d-dev@openjdk.java.net></a><br> \
<b>Subject:</b> Re: [OpenJDK 2D-Dev] RFR: 8223935: PIT: \
java/awt/font/WindowsIndicFonts.java fails on windows10<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Done.<br>
<br>
<a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Eprr/8223935.1/">http://cr.openjdk.java.net/~prr/8223935.1/</a><br>
<br>
Log looks like this :-<o:p></o:p></p>
<pre>SysRootDir=C:\\Windows<o:p></o:p></pre>
<pre>found:C:\\Windows\\fonts\\mangal.ttf for Devanagari<o:p></o:p></pre>
<pre>found:C:\\Windows\\fonts\\vrinda.ttf for Bengali<o:p></o:p></pre>
<pre>found:C:\\Windows\\fonts\\raavi.ttf for Gurmukhi<o:p></o:p></pre>
<pre>found:C:\\Windows\\fonts\\shruti.ttf for Gujurati<o:p></o:p></pre>
<pre>found:C:\\Windows\\fonts\\kalinga.ttf for Oriya<o:p></o:p></pre>
<pre>found:C:\\Windows\\fonts\\latha.ttf for Tamil<o:p></o:p></pre>
<pre>found:C:\\Windows\\fonts\\gautami.ttf for Telugu<o:p></o:p></pre>
<pre>found:C:\\Windows\\fonts\\tunga.ttf for Kannada<o:p></o:p></pre>
<pre>found:C:\\Windows\\fonts\\kartika.ttf for Malayalam<o:p></o:p></pre>
<pre>found:C:\\Windows\\fonts\\iskpota.ttf for Sinhala<o:p></o:p></pre>
<pre>found:C:\\Windows\\fonts\\dokchamp.ttf for Thai<o:p></o:p></pre>
<pre>found:C:\\Windows\\fonts\\dokchamp.ttf for Lao<o:p></o:p></pre>
<pre>found:C:\\Windows\\fonts\\khmerui.ttf for Khmer<o:p></o:p></pre>
<pre>found:C:\\Windows\\fonts\\monbaiti.ttf for Mongolian<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>-phil.<o:p></o:p></pre>
<p class="MsoNormal"><br>
<br>
On 3/17/20, 11:24 AM, Sergey Bylokhov wrote: <o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal">Hi, Phil. <br>
<br>
Probably it is better to use "%SYSTEMROOT%\Fonts" instead
of "c:\\windows\\fonts"?
<br>
<br>
On 3/17/20 9:34 am, Philip Race wrote: <br>
<br>
<o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal" style="margin-bottom:12.0pt">Bug: <a
moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8223935">
https://bugs.openjdk.java.net/browse/JDK-8223935</a> <br>
Webrev: <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Eprr/8223935/">http://cr.openjdk.java.net/~prr/8223935/</a>
<br>
<br>
WindowsIndicFonts has been failing randomly depending on
<br>
whether a test system has the Indic fonts installed. <br>
This updates the test to not fail on systems which don't
have the expected <br>
fonts installed in the typical default location. <br>
<br>
-phil. <br>
<br>
<br>
<o:p></o:p></p>
</blockquote>
<p class="MsoNormal" style="margin-bottom:12.0pt"><o:p> </o:p></p>
</blockquote>
</div>
</div>
</blockquote>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic