[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [15] Review Request: 8238075 [OGL] Delete unused properties
From:       Alexander Zuev <alexander.zuev () oracle ! com>
Date:       2020-03-11 14:49:47
Message-ID: 2eac6bd9-4ee4-23f1-f81e-0ced6ec66019 () oracle ! com
[Download RAW message or body]

Looks Ok to me.

On 29-Jan-20 7:15, Sergey Bylokhov wrote:
> Hello.
> Please review the small cleanup for JDK 15.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8238075
> Fix: http://cr.openjdk.java.net/~serb/8238075/webrev.00
>
> The OGL pipeline on macOS still used some properties:
>  - CGLGraphicsConfig#kOpenGLSwapInterval is not useful since we moved 
> to the CALayer
>  - CGLGraphicsConfig#pixfmt never used
>  - Initialization of CGLGraphicsConfig does not depend on displayID 
> after JDK-8223158[1]
>
> Also I simplified the native initialization logic of CGLGraphicsConfig.
> Previously we create an array of parameters and passed them to the 
> selector, also we
> return result via the same array, in the fix selector was replaced by 
> the simple "block"
> passed to "ThreadUtilities performOnMainThreadWaiting"
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8223158
>

[prev in list] [next in list] [prev in thread] [next in thread]