[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8221741 ClassCastException happen when fontconfig.properties was used
From:       "Langer, Christoph" <christoph.langer () sap ! com>
Date:       2020-01-28 13:23:51
Message-ID: AM0PR02MB57141586FD4FEC603645EF2B8A0A0 () AM0PR02MB5714 ! eurprd02 ! prod ! outlook ! com
[Download RAW message or body]

Hi Matthias,

thanks for looking at this change.

> Some minor nits :
> 
> SunFontManager.java
> 
> - Why did you add the initialization ?
> 
> 954         PhysicalFont physicalFont = null;

This is required, because in line 981, physicalFont is returned. With my changes to \
line 976 it is not guaranteed any more that it will be initialized on each path of \
the code so javac would complain.

> 
> 
> - Copyright headers of the java files should be adjusted to 2020

I think since I've done all that work in the last year, I'll leave the copyright \
years as is  - unless I have to do further changes.


So, with your review I think I can push this to jdk-client. I'll do that soon unless \
somebody wants to object in the last minute.

Cheers
Christoph

> 
> Thanks, Matthias
> 
> 
> From: Langer, Christoph
> Sent: Freitag, 24. Januar 2020 09:52
> To: Phil Race <mailto:philip.race@oracle.com>; mailto:2d-
> dev@openjdk.java.net
> Cc: Ichiroh Takiguchi <mailto:takiguc@linux.vnet.ibm.com>
> Subject: RE: [OpenJDK 2D-Dev] RFR: 8221741 ClassCastException happen
> when fontconfig.properties was used
> 
> Ping…
> 
> http://cr.openjdk.java.net/~clanger/webrevs/8221741.1/
> 
> May I submit this fix to jdk-client? Or what would you want me to change to
> get it accepted?
> 
> This is running for weeks now in our CI infra (on various systems and
> platforms) and showing no problems…
> 
> Thanks
> Christoph


[prev in list] [next in list] [prev in thread] [next in thread]