[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] [15] Review Request: 5085520 Inconsistency in spec for RenderingHints.entrySet(
From:       Jayathirth D v <JAYATHIRTH.D.V () ORACLE ! COM>
Date:       2020-01-23 6:40:40
Message-ID: 99597A50-6A31-4F43-98FB-6E38F9C76B91 () ORACLE ! COM
[Download RAW message or body]

Change looks fine.

Thanks,
Jay

> On 22-Jan-2020, at 10:49 PM, Phil Race <philip.race@oracle.com> wrote:
> 
> Looks fine. You could have added that the Set is unmodifiable but it is not critical.
> 
> -phil.
> 
> On 1/20/20 9:02 PM, Sergey Bylokhov wrote:
>> Hello.
>> Please review the fix for JDK 15.
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-5085520
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8237563
>> Fix: http://cr.openjdk.java.net/~serb/5085520/webrev.00
>> 
>> The java.awt.RenderingHints.entrySet() method description says
>> that the Set, returned by the method, can be changed and these
>> modifications will be reflected in the RenderingHints. However,
>> the last statement of the specification prohibits any
>> modifications of this Set.
>> 
>> In the fix "and vice-versa" part was removed.
>> 
> 

[prev in list] [next in list] [prev in thread] [next in thread]