[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: [OpenJDK 2D-Dev] RFR: 8224109: Text spaced incorrectly by drawString under rotation with fractio
From:       Alexander Zuev <alexander.zuev () oracle ! com>
Date:       2020-01-17 7:57:24
Message-ID: 3809c7cd-795e-2fe9-e916-45a4f15295e8 () oracle ! com
[Download RAW message or body]

Looks fine to me.

/Alex

On 1/15/20 09:23, Phil Race wrote:
> Looking for a 2nd reviewer.
>
> -phil.
>
> On 1/11/20 4:12 PM, Sergey Bylokhov wrote:
>> Look fine.
>>
>> On 1/10/20 1:33 pm, Philip Race wrote:
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8224109
>>> Webrev: http://cr.openjdk.java.net/~prr/8224109/
>>>
>>> There have been at least a couple of reports on this problem which 
>>> manifests
>>> when using fractional metrics.
>>>
>>> As noted in the bug eval
>>> - we had the wrong sign for the y advance in this path
>>> -  the wrong transform component was being used for the rotation.
>>>
>>> The fix is quite small but creating a regression test  was a challenge
>>> to be able to reliably tell where the rendering landed and if it
>>> was the same for different APIs and that it goes in an "expected" 
>>> direction.
>>>
>>> I found one new bug 8236451with a laid out glyphvector which is
>>> not fixed here because it is a harfbuzz code path problem.
>>>
>>> Also we have known issues with AAT fonts and harfbuzz so using
>>> Courier New on mac.
>>>
>>> Not to mention Macos Mojave wants to do AA text even when you
>>> ask for B&W (bug open on that too) so it is really hard to verify in 
>>> that case.
>>>
>>> -phil.
>>>
>>>
>>
>>
>

[prev in list] [next in list] [prev in thread] [next in thread]