[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-2d-dev
Subject: Re: [OpenJDK 2D-Dev] Fix for 8235904 "Infinite loop when rendering huge lines"
From: Mario Torre <neugens.limasoftware () gmail ! com>
Date: 2020-01-15 1:09:06
Message-ID: CAGUMyaRcuw-rxFvGZdi7h_WGchcAyHY7pGJGZH60VhwcesXv6w () mail ! gmail ! com
[Download RAW message or body]
Thanks!
Cheers,
Mario
On Tue 14. Jan 2020 at 22:58, Alexander Zuev <alexander.zuev@oracle.com>
wrote:
> Hi Phil, Clemens,
>
> both code change and test looks fine to me.
>
> /Alex
>
> On 1/14/20 12:33, Phil Race wrote:
> > Here's your webrev with a jtreg compliant test added :
> > http://cr.openjdk.java.net/~prr/8235904/
> >
> > I verified the test behaves properly under jtreg -
> > before the fix jtreg kills it on time out
> > after the fix it finishes quickly and successfully
> >
> > Outside of jtreg it also exits properly although jtreg is the normal
> > way to run it.
> >
> > This is all +1 from me but I think someone else should sign off on
> > this too since I
> > don't want to self-review the test.
> >
> > -phil.
> >
> > On 1/12/20 11:54 AM, Phil Race wrote:
> >> Hi Clemens,
> >>
> >> That needs reworking in location as well as adding jtreg boiler plate
> >> and legal notice. Also there are code changes required to be a well
> >> behaved test. I need to sit in front of a headful Linux system to
> >> test those so I will have to follow up on this (hopefully) tomorrow.
> >>
> >> -Phil.
> >>
> >>> On Jan 11, 2020, at 12:40 PM, Clemens Eisserer
> >>> <linuxhippy@gmail.com> wrote:
> >>>
> >>> Hi Phil,
> >>>
> >>>> Is there a regression test ?
> >>>> I don't see a noreg- label.
> >>> Sorry I forgot to mention, the regression test is in the "main"
> >>> directory of the bugfix:
> >>> http://cr.openjdk.java.net/~ceisserer/8235904/
> >>>
> >>> Thanks and best regards, Clemens
> >
>
> --
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA FC7C 4086 63E3 80F2 40CF
Java Champion - Blog: http://neugens.wordpress.com - Twitter: @neugens
Proud GNU Classpath developer: http://www.classpath.org/
OpenJDK: http://openjdk.java.net/projects/caciocavallo/
Please, support open standards:
http://endsoftpatents.org/
[Attachment #3 (text/html)]
<div><div dir="auto">Thanks!</div></div><div dir="auto"><br></div><div \
dir="auto">Cheers,</div><div dir="auto">Mario</div><div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue 14. Jan 2020 at 22:58, \
Alexander Zuev <<a \
href="mailto:alexander.zuev@oracle.com">alexander.zuev@oracle.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Phil, Clemens,<br> <br>
both code change and test looks fine to me.<br>
<br>
/Alex<br>
<br>
On 1/14/20 12:33, Phil Race wrote:<br>
> Here's your webrev with a jtreg compliant test added :<br>
> <a href="http://cr.openjdk.java.net/~prr/8235904/" rel="noreferrer" \
target="_blank">http://cr.openjdk.java.net/~prr/8235904/</a><br> ><br>
> I verified the test behaves properly under jtreg -<br>
> before the fix jtreg kills it on time out<br>
> after the fix it finishes quickly and successfully<br>
><br>
> Outside of jtreg it also exits properly although jtreg is the normal <br>
> way to run it.<br>
><br>
> This is all +1 from me but I think someone else should sign off on <br>
> this too since I<br>
> don't want to self-review the test.<br>
><br>
> -phil.<br>
><br>
> On 1/12/20 11:54 AM, Phil Race wrote:<br>
>> Hi Clemens,<br>
>><br>
>> That needs reworking in location as well as adding jtreg boiler plate <br>
>> and legal notice. Also there are code changes required to be a well <br>
>> behaved test. I need to sit in front of a headful Linux system to <br>
>> test those so I will have to follow up on this (hopefully) tomorrow.<br>
>><br>
>> -Phil.<br>
>><br>
>>> On Jan 11, 2020, at 12:40 PM, Clemens Eisserer <br>
>>> <<a href="mailto:linuxhippy@gmail.com" \
target="_blank">linuxhippy@gmail.com</a>> wrote:<br> >>><br>
>>> Hi Phil,<br>
>>><br>
>>>> Is there a regression test ?<br>
>>>> I don't see a noreg- label.<br>
>>> Sorry I forgot to mention, the regression test is in the \
"main"<br> >>> directory of the bugfix:<br>
>>> <a href="http://cr.openjdk.java.net/~ceisserer/8235904/" \
rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~ceisserer/8235904/</a><br>
>>><br>
>>> Thanks and best regards, Clemens<br>
><br>
<br>
</blockquote></div></div>-- <br><div dir="ltr" class="gmail_signature" \
data-smartmail="gmail_signature">pgp key: <a href="http://subkeys.pgp.net/" \
target="_blank">http://subkeys.pgp.net/</a> PGP Key ID: 80F240CF<br>Fingerprint: BA39 \
9666 94EC 8B73 27FA FC7C 4086 63E3 80F2 40CF<br><br>Java Champion - Blog: <a \
href="http://neugens.wordpress.com" target="_blank">http://neugens.wordpress.com</a> \
- Twitter: @neugens<br>Proud GNU Classpath developer: <a \
href="http://www.classpath.org/" \
target="_blank">http://www.classpath.org/</a><br>OpenJDK: <a \
href="http://openjdk.java.net/projects/caciocavallo/" \
target="_blank">http://openjdk.java.net/projects/caciocavallo/</a><br><br>Please, \
support open standards:<br><a href="http://endsoftpatents.org/" \
target="_blank">http://endsoftpatents.org/</a><br></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic